Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Feb 2009 13:04:45 +0000
From:      Jens Rehsack <rehsack@web.de>
To:        John Baldwin <jhb@freebsd.org>
Cc:        freebsd-stable@freebsd.org
Subject:   Error compiling FreeBSD-Stable with MFC'ed iconv locking
Message-ID:  <4996C16D.8050909@web.de>

next in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
Hi John,

after I updated my system (-STABLE) I received following compilation error
while building the kernel (having ICONV built in):

cc -c -O2 -frename-registers -pipe -fno-strict-aliasing -march=nocona
-std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes
-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
-Wno-pointer-sign -fformat-extensions -nostdinc  -I. -I/usr/src/sys
-I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include
opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100
--param large-function-growth=1000  -fno-omit-frame-pointer -mcmodel=kernel
-mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow
-msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Werror
/usr/src/sys/libkern/iconv.c
/usr/src/sys/libkern/iconv.c: In function 'iconv_mod_unload':
/usr/src/sys/libkern/iconv.c:92: error: 'curthread' undeclared (first use in
this function)
/usr/src/sys/libkern/iconv.c:92: error: (Each undeclared identifier is
reported only once
/usr/src/sys/libkern/iconv.c:92: error: for each function it appears in.)
/usr/src/sys/libkern/iconv.c: In function 'iconv_sysctl_add':
/usr/src/sys/libkern/iconv.c:401: error: 'curthread' undeclared (first use
in this function)
/usr/src/sys/libkern/iconv.c: In function 'iconv_converter_handler':
/usr/src/sys/libkern/iconv.c:452: error: 'curthread' undeclared (first use
in this function)

I applied following patch - and it works:
--- sys/sys/sx.h.orig	2009-02-14 12:56:11.000000000 +0000
+++ sys/sys/sx.h	2009-02-14 12:57:33.000000000 +0000
@@ -35,6 +35,7 @@
 #include <sys/_lock.h>
 #include <sys/_sx.h>
 #include <sys/lock_profile.h>
+#include <sys/proc.h>

 #ifdef	_KERNEL
 #include <machine/atomic.h>

Google didn't find anything so I thought I mail this quickly.

Best regards,
Jens


[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.10 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQIcBAEBAgAGBQJJlsF0AAoJEIc3wDcpRJzFBkwP/0h3ifjg5FUatHlyiWM/ZqQs
xkHSDkq3zn2NacHyGFwqF+Bd9bV+yLKlQvCQAm7bKByhHZMyqB3PV7kKpMEFjZ9n
5tuVKbG6ikctP8eLdnfbckZFm+bbgWJQ2IUkcG/q8/WKC6pCODvjipYoWdpKx0iT
PYUUNxeu8mIDZ4U6WkOjXbxRvJG/yrPAmqal9XfhydrDyhqLQ2BzaaFLVzEzbqmn
jZdinwmiSssoARw2+h4Krz3YoR5TCJ1k27C8PNPE7w4uSoYXIL8RQE3Ou+6P2TRR
ejpm38QK+QeePjBv+TAUIaCho+KG5FW1pgNwut54OdQ/wXUXiKRtyVacd6e8XkeM
HY/yQVMwX3VakCwMreNRtGw0r3sgASF5lvloMSsaPPmta8YCvk4YogFGz8kzkg5q
aWjMf2Id/tl1A38FR98NqEcmW5JsHXipvyES+gM+OOdA2bOVjI9ac1fBUvn0YaMO
GHHtIY5L2LTZNCkWG+to5newy8TUy6gHv/w/mS1PiYtR9Yi29z0UXHn02xPi/3lK
lKx3/L2yE4S4puGBp/QA4borqaQaZqJijEdM72BbKK0sIxC1XCqvcX5/8hAmA13x
PBHTn//npWwgZ4kAmAa6BJQ80p/oClMO1MLICOiOhFOcm2GdwKNDfN6mTKQlyssx
37HKmanth4bBgOj0nfJF
=e2/z
-----END PGP SIGNATURE-----

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4996C16D.8050909>