Date: Sat, 30 May 2009 16:15:32 +0200 From: Gabor Kovesdan <gabor@FreeBSD.org> To: Ed Schouten <ed@80386.nl> Cc: ports@FreeBSD.org, gerald@FreeBSD.org Subject: Re: [Patch] Proposal: USE_GNU89 switch Message-ID: <4A213F84.1000704@FreeBSD.org> In-Reply-To: <20090530140800.GR48776@hoeg.nl> References: <20090529123633.GM48776@hoeg.nl> <20090530140800.GR48776@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
Ed Schouten escribió:
> Hi,
>
> I'm proposing the following patch:
>
> --- bsd.port.mk
> +++ bsd.port.mk
> @@ -2180,6 +2180,10 @@
> .endif
> .endif
>
> +.if defined(USE_CSTD)
> +CFLAGS+= -std=${USE_CSTD}
> +.endif
> +
> # Multiple make jobs support
> .if defined(DISABLE_MAKE_JOBS) || defined(MAKE_JOBS_UNSAFE)
> _MAKE_JOBS= #
>
> I thought it would be better to add USE_CSTD, instead of USE_GNU89,
> where the port itself can specify which C standard to use. This will
> also allow us to force builds with -std=gnu99 when needed, for example.
>
> Any comments? Anyone who wants to integrate this patch into CVS, or
> should I do it?
>
I don't think it's a good idea. This knob is completely superfluous and
thus should be avoided. One can just add -std to CFLAGS from a port
Makefile. Forced build are also possible without this stuff, you can set
this in /etc/make.conf.
Cheers,
--
Gabor Kovesdan
FreeBSD Volunteer
EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org
WEB: http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A213F84.1000704>