Date: Sun, 21 Jun 2009 19:02:14 +0200 From: Michael <freebsdusb@bindone.de> To: Rui Paulo <rpaulo@freebsd.org> Cc: freebsd-acpi@freebsd.org Subject: Re: Two new acpi modules, acpi_wmi and acpi_hp Message-ID: <4A3E6796.4010501@bindone.de> In-Reply-To: <8F2C596E-1B49-4E15-ACC0-84C1A14BD245@freebsd.org> References: <4A3E1784.2050406@bindone.de> <5AFA3C27-D3DB-48DA-9AF3-9E14D11EEC61@freebsd.org> <C0DCC4DA-5E4C-46B2-9B84-4EBBC5920B3D@freebsd.org> <4A3E6563.7040400@bindone.de> <8F2C596E-1B49-4E15-ACC0-84C1A14BD245@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Rui Paulo wrote:
> On 21 Jun 2009, at 17:52, Michael wrote:
>
>> Rui Paulo wrote:
>>> On 21 Jun 2009, at 15:08, Rui Paulo wrote:
>>>
>>>> On 21 Jun 2009, at 12:20, Michael wrote:
>>>>
>>>>> Hello,
>>>>>
>>>>> I wrote two new acpi modules last year and finally found the time
>>>>> to fix
>>>>> them, add some missing features and write man pages.
>>>>
>>>> Michael, this is great work! I'll review and see if we can ship it
>>>> with 8.0!
>>>
>>> Michael, this looks good, but there are two style nits that we need
>>> to fix.
>>> * we should try not going over the 80 column mark
>>> * add a empty new line before every return
>>>
>>> If you could send me a new patch for 8.0 with these fixes, I'll commit
>>> it (unless someone else has objections).
>>>
>>> Regards,
>>> --
>>> Rui Paulo
>>>
>>
>> Hi Rui,
>>
>> I figured that adding newlines in conditional returns makes no sense
>> (see my last post), so I did reformat everything to be (close to) 80
>> columns a line add added newlines in front of returns at the end of a
>> function.
>
> Yeah, forget about the newlines before return.
>
>> Please find attached the complete patch again (against clean
>> 7.2-RELEASE) and the files that changed (acpi_hp.c and acpi_wmi.c).
>
> Can you send it in MIME format or store it at some webserver so I could
> fetch it?
>
>> Btw, what is the normal adoption path for 7-STABLE (I would assume first
>> it gets into HEAD and if there's interest there will be a backport to 7?
>> It should at least work in there, even so for HP laptops my guess is
>> that most users will use 8 anyway because of wireless support).
>
>
> It first goes into 8.0 and then 7-STABLE.
>
> Thanks,
> --
> Rui Paulo
>
Hmm, that should have been MIME Format (are you using MacMail by any
chance - seen issues there before..)
I attached it again as an archive, does that work for you?
cheers
Michael
[-- Attachment #2 --]
g>J {90|şB$`$3xǓ'ۆnCC39ԭ3sy<KT*J*?{w|OPثT-/ȿExX(bTܯw{P,K#M3 e`}5a_%?;[
%jי}{7~F
CqfLk(ގ=?,|;FUCA1k9j[ۙܞ9c LEO9*n&NLfw#d`}qd9Ȟϭ&_|ߙseprooE2XA,Xnd͏s1 ES2 H` hZy=d!Ov!C4^<?MPih#k}$JaBBG!>n4#k<7ՠxLL̹5͡u<
"֛V{Um>_[u.N>KCT/ZmQ=Zn\v[
_ƯmPyvq4]=6NV4k۬ ,ͳf,V%E!Όv|4ODP=Hi-..af՛iyf8λL(*ZYoZ}AqYѹ0jM`j@KYc%bWϪom%RlgH/Cmv/xj;
wfV:cdn,[>\von_^t"zbPN}:6C/
AV\3yz}сޫu BvƊsiq^3m]5;FFA&|U@mXmQc,h6DK`NSL:wqll*?:_qwo6zIެ7
9ءS_`|fj<ywc\ YԆB|2%yG)ΚXyMFS7q[,LIBL^ɽ#!k%e,L{<ng&;s6G) UX9u7,nDIU4ԞA$B-vX`h:Pa r;"}7:S{xPb[
} ԄH:q7OvvJr/QvM~<䧃4LTc1`fckn%g&fNT
;6sk3OL#gtޣwޛ3s`&taOAOeCϯNs
ЊZ{AiX_v}sb|7a:g`Om
&=D:h@LZ}8k/OyHoxendeJm6JaR?UJ|j+6#QXv'-ʹʮq;1rR1J¾Qlbr+@J\ȝ4\Z
&
K3کC1]ޅUI+EUO;. +m~0U"`<F
VwuZ=BptvlT:TWm,܆pfBT* tyHڍ+rrzit[y[m${TdNe`^iY+}4y3bI!($Ŏ;p8"vPԍny/v~ tH $aOCkU#[x8XZi 6RPtہ[Z-
0oz\gz
qZ}`
-saEgyϱ~MM{&~H]R_.ΖP_x1t@M9kv9v⠚BRT'Nۅ=@o!P5#)Æ7V~j@Zk
no,MKU#nhC.ԧJ=ei#E?Qa&㡸ꠗf&cZ@|$.6kV[[vHQL=`Z1(g p kT'Q;ȹZBdnf?q'=8M~[K 6_R[wS/9COW7h).)\pOFŦsJLָO|h`5qCϛuNb::d ō5S@ ;
Yϱ?kOd:SؘuGpt?KC'\)gf ɻdWfՕ]}!ׇvjkl,)Fn28VoӟS `Jx'G?kD 1z-6514+_&(U²SiLO솝aL"uO.@E:?LF[6@GkzqD
SnE44_(nPvhAKNZqWxzy!odlG&'s@
QxT|\Up=_qfډZH*,cGQl
h[iwPϻ
瞂.16 f*B+1I1)OtZoyww]=ww]9+_^d^u.+_ܶh^ifgY(mɉd<_P(Mq1a
`Oeh봘YKH(!zML!Z#{
6БO%$Ips[tQ%Gn%5m 7fs=ViVF=cS vfa.zwy&VZpcp|nV >
*/hpPs0V\Q`JG`ݏ·{N<l-G 8W >']4qc22uM2
V̞[ Uy6h5C
زkJ-<@єB;{dw
;@9"CL#+!`\/ndW,?e%φm);@/4ltZY=p E~ zASCfIѶvv9BV_X3%kQ7ڝ&yn<
7_]#kW|K6qgֺvEb=YEl G@;³G79hCM%uAs-2MѺE=z c(ך }\qb`Aݸ0~<(H'`FA,ޞYC)ױufw^ĵ=4Yt#PjN?FI")ChuL:rE8HN#Q>vO3hǍ"621/Cb@rqF,xv;eefZ"PN3dhN~3YlKD5Dg_=ҿ)ld|w|VcZYV&A;y"e\d63$jNIZO߹饤>v?<}&yu3Ӛ]}/ц
62zXGR4G34Q3=+ؼE! ֟GxZPK\W*⍈p$uȧJ|-ޚl6L\̿^E0Td?ұf1A,gEYxz|sZlQlM#QDg@`E|ɟ>X:bӥ:0RTՁ7oZ&҉w7&}ĻxL<i͎qڀ033f}Č6|9"WAvj6؞cYu3"m
4q/<.aGYM
7W93rR>erۗ$y
抑&cʤ 85#zŸQc>]Tw-mĘ!w#7KXe<G7h$*nQ` ,T!}
zfCϙH!Gֈ: mJAa̦U㈩O>JƋ$̦7x ]͌TbYmƯ
"..I$I<_=x]Dt
}tQ rbhF(e;АJ{"
T'A3I7@ts"[JSHn,h9[5Ȳv8~/nNzz*6eʹGgRig
GδSP/KjdXO Zy&4_+Yߎho5=7|d~FKݮLIov[xp0iR*G:ƁO/ER ʣS>
{j*M(x<OMjU.}/eCk$8Px/Mg'DdDg۱ޖ]+j/LCXڪGdS2h́$>_i1&9=g5i(d<ifc~vYGXX=^XJF
t &G51%*x->S.iVq^G9^K%Mփky: ]2YQYT*FxdƚL),A 8
t';Rx.Dث(
K7P%?b--!
1،%~q,]YPJt"Feah9{#Rx:wkxy5~>|<+5zc9 "n,xL 4<ؚ&j#ߑ1[5+9yL4~QU7+ѮJhBJ($iz\!H³FڃʬxI.'ͬx`fܛu/<6%',/
".a=_bʝcGrxow"-0x:YHaɱ:PXis"b
g8\8bЪtՉ
+ FpG)#0.:;|ԺZNs:a렂Q'|xwZ&_(֗WܾZWn_urjmH֘^An^=_zybkqMS^@xb ?+-o<@UݪFkAVջ:g-A߮v{:ϪoD^$ܡȸS,><aUtxW|\@س`MrɩR-*gCbϥ'GGTP:b'ؑZr=*qSy8ꯘfB}YJrE.<b?\<TW7/n;@ɺ׳CK7ܵLVɞ\6FnЂKy\p4^L`Hմ߭W#NZסq"ܻ,⬬\ٵ8ɘnX==mժ]CBCMkèu?r[+z奪ls+R#!ro_{Ew&eK qC l|ҁ] î2% F+rk%ُ:w6dR3
OTI =ڐ
E<hb8O90ȑ^LLc?y%'*(&:Dp2 o.ۆa^" K=ģfQ(~Eo<y!0L_?иE]+09\LҖ7&\c铤O~/~o6lq<3}ƕt;ӝ$3{|'G
l6:pQr/ c:b%I}:CHMtG
o_NxGzٰ?&zur0`Ո+P.&#x"C'yu88ݘ&YZ+Z;K;p 6K>AYX-Q[GOk^ak4$X(%t0YgV!P>CJV-yg[3sֿ+PM5KzS72>Cs|^ҫ)qqձ[`Wp{2X'vC<7zڼv&["MntfͰv?>@&ޗQ/ӀA@W*A g#oTĎ}rdi r 1/ASfHD>dvKR&]TOZ\W5>["CKM\ݕGA]"RV' &^jer`%C[TO_ӻ=T[P {lSBizéSF8@
f^erCʳ0G6i Ckp˱26o|mܽ0X-[KJ]娒-IE+/{/dz*N~<3#)Wby;u~5Ǥӎ)S#/K)i~VM@*Ҩ26rJCԜ
D妊^Ɖ)0"&J%ۯE29Kb3!H
S?O{
+GkNКAVRdUDZb*77sކ~dehd_zQCW;V
^N#Ra؆ɶ~D
LcUʽ,J2t #g-M4Jg`Zdt
"8?P^W
Wj<.zǁt> [KyIEblz66J,v@)>.y7˷XQ*ӪV&yh"5[HD[6Fgd>q[cYid_;6PU[Kܛq<CpS{ [)H]k6y*mDڇnIh;-jp{Aߓဉ É|
ď|7|~uHK{/U5 '2ån|L)mV)F Q
_b)74DJ}n|PF y[d` hR\:..%ea/HY[2[%O?bEKa[No.f~(AabW
<{7x5FjOnN#.B|\kD^BTѝ2j+49,'C/2\AR|?=n`˻6pn#]Ѳ*b n+ArY\D*]
WbT
ɧ.touu"V
{Y9lu.q^H&{߯Pa$
a73N)Éֽç
yb{#=)U^XG_qKө%1=ƤdL~H}|'z4QʀO'hfB-=Dv-jUHҮXݧJLjr7z03x̄/&0ikD4pt1<O}տĆo|۾蓕?ߋVE@$o X<SM9y[Д
n!R9' } A,=0N?40xcqk">vWc*8Ir9۫;Z T!%&|BhK$E7܋>nrMDrq^8Wd:6<w7H0$!h"L%oE.UiÍJքUZgYP_Cg=N|7ȊxrsHdCr 0&_,na|qh$#ِPa2\[KJ$
sFnW)bTܯwEQ(VG6RY0Q;P]~vrlV~Qt?#J¡8AUA!~D+ݵ3vf
9Af;X; w &g'}E%rNō7-#4x/cm
`bK1fF֜| izHL#F*(f<=H}`QUK=fdu,
Q@;hJi0/dkAA&x?CkfCx0D7C1@]#:F6|4ߵڢz^y<mz#j_WeEth]6
mWϻMey6+ 8ouin+ՑZh5ęѮՓij4X] vY<e!lجzS;6όz^ P iyW]L(ċV֛mxjg@iVt.Z?ВjCV xճ[h[zI`˶qB?t.O:fkV =,@5s,N[ˎN-x
O.;M7<ro//]
:B:q}j@4YqmR*MZ?ZcŹ8## @k~6^Rq6nFT4ZD%0A)y@L;yڣo*?:_؍87^Soӛ
ՔuZ*).9}8اY5pRr1k<?DLhG0ҏ)mo%B n|2u2ytK*k 6q_fΆ٩MffnL* 9$ĩ=^<(]P둸ϧG;;ݟM"OF;wLl:尷#g@B_u[gk660RG6G8~aoOAU?DB%|dGE3~~ Ӟ/kJ\-;`hs{7Sgث
#i!1 )|rqJP.Z _qdꙑTZi|o
E%#a<NVaןRc:}F|C%=ӂee
ԉrË_`іL=K~n4Ɣ*lNw]"HrD2*P//
bIX}Əe_гlsr@6N'Krz}1
%-Wݴ""k]U UtDaUo2d8|Qc>S8@4FPzW0nѸ)/I8X-F*^l@'2vpA~>p2B&<J3P@k852zyxW˙{6Jt0bV܂Mŕ jzX"=Lnn.tac8* 87Uk-~hi#0$ZpORFn(Np2d쓼>$~?{@[CZ=;G\HoS"azcAőKqpD=ԛAPҩTjW&-҇ۖP-{gTnèM;LfvB}0.^^*rm?LTE/זjQ6,|#հ&Wyk
J`9bTAp3,4ɳ,/#@i= š|x
H>Vr&(=
2Ɩ=T?pgG5 bک+8}5dtTpiJ@C8Xջ:z5p3Usg
>;<fRb~n}Dv~uCYR^2C*_Fo} 3thT;!(szsл;>Zrz"|'u1=W;b<?+oBoc=箦_j%J0oZRp[p1 \{nm[5Ԡp*`[\51+"
dtNb2t^=eyWOkd#.QUEi_VM42TJB$U"q*
ĠZ#$$H3Q4g)R|NZK3K
6)$-FF0)]4L1IZ,dijoJs
Zc>ϕgY.}A2DhbRxxxŧX'*eC7YmmD:%I}$ȋW:ỦSܳoa3Q6) ȩ~ER$ڼf^nhT`[i φ@L813AS2$ΏI姨dLTڳe)p6ˠ W_UP\ 1zy`ksoq$Ck4<{u܆&*Sg
^2P
GFt9IOGȽ- v.bT-ɔ\]Y3Vk:0e؍O?b_%~r
hR@e
yoQN
٘ͭ̚S23zm!^#~!Dl0k:Hk8Qc%#I1IJ_Evzk#NѰGqr6
V1KWtߙs7.,aXE8IMPCBOQ۞.*Xˬ2u=.Q Kmü5xξ5;{8/q{bbk>B?bjY҃,{AR_זJxBϺC6wNaxU [vA+wj|mE;.,k:bW'CriE'@_@"퉗nC[58F^|["j|R+D."{,ym4upCTONjz=gFwr?ӳV\QĴ
jG38_'GkҍzUáNۏY j(My#6#M< $X"fЈ<y҃7M-??,:)X4+|\&?N._yW2Gyuy4-Yk7_D(mG\]%=O
* E(yRSD^CFpNQx.*TcjpR@J>(_`]Pŕp,U8xż7(5@j#+p#UcGBFU~
o:
y=W`={sBF zMDH/&^eiYikzPR)ؐҪlZD%F!B2krie2֧e6uaL h-GS'T31JEZZrCI$bR1w1;ޣ?9Pxe`u/ Eo=+5e%5L)n
K^a8rh#^HMCZT#jtTq獅):e=eފB KO^{x>Sc'bG"7]B4#5p(Nϕe5S͍ę8|)"lz<ܾ0=v_%yBշl٠ mEA
@<¹y\}{)M+*aZlTK֦h,+xvuwRJ$K[Dk'~^&^BWa4H-Ey!VTO3f
'D)d6dzk+]3_LX5d
Q+H/_\A[X\I-?M^y XlNf
H=˗^ZI_]v-VQj@!U
i
Z ,}:ZUTb8^EP!U]oǓo:).͛z6}Pw\78RPQ~o_xO~q%BwE"-J%+sMC;S;Tnxn6AoY_Tqd6 .w.1 ,Hjh˜[^_eN^~`
$D|_#QOIGK25|Z[]J^]eft:i-T(NK4yIA=ٹy:s[%: ї1CfΎZ_w!ݚ8\xCqg^PDMOS%u+
w6Pi_3h ҧU#/MX0gg-xu%bZurzr;M
7pۙb##-|&vS5AҜ
Ug]YDՄ[|Xl)`ljЧi
Yr3ˤRˌ2m|dAQP:dK,q7*C2˴e,:<#e
F;*G{2uH]ida#r%[{sr+%WJЍGu&,*ۄmO[h;q9@+샚"D]' m
v0SqN1tCC FrBo}t~٥q[T6B)y* +%&y@soZO<Hˑǁ0dՠ(l0i2M/PH݈TWf %iI2(捰3Ǒ}`ݘjwRWJ#1Y.~Hu*F|:= -{.qg"Υ|kV~c֤bOQY4ÛNktn. A}-U;Z"0ZM AfԤ;8=I][Xf0̓?nhhUJ`{tja[֮"fg#ZeC3 t)VU12zs$Wc[L CEB6;Wج@6P7~Y-UX2L?]r_G$2qt6Hm {&sI rtgN֘2ΖUAFX-DX/00E'S~TSʯ~T]Jϕ"Ɣ+%(7>{z#OX=YI։Y2DF
:(%Yݨ7_Zi,j$죠7QPsߴ<S^p9݈B9Ѻ#=+]v$굓jx_N[.]Q kSq%?0*abc;%#8K<1j%ͫJk&E$bNJ6|,Q6YQxݬأO|
[C~Q"łP<GX,H]ﮒQYբIT$ɗNsr3#t;ޓ/ 8)G4=
%JR:fb8됁Ec-X9L^uX0(EP״?qc吉9@<1׆۠o:F~M^4s*R gx+ϗ..s_sbvCv'8G0t)w$`hk2:7{ws:OBTLA
d:{<9;-rJv(GcJg==I_mzt6C83#0_ΉYZͺ{⧻G[zJ}߈(~X}?ܮ#=9{/KCQ}(|wz{|n-n5ŒĥXq?*Xg>8eh$yyޒɬB2ˮ2<RWg?Ma (uU%^>[XyfnU\Mz齍s^o#r4M5mWk?h暣#
29CkztGXbǵD
9ι?LRFqIJG?y}1Q؏e=¤_Jyr{:?*{T)/0<]>أDV;筮*rCQU{ۅbU
{RQKGBTٟ~1'ϡ
1O:ln?>o9^!6aV2ƶ(v\,QTEd87o15fō9leד3)jAY6Ebo,cϝD,'0\p.TPZ.<9sˋWsf~nba,[D3G>'\ԛ["o
R/_Ƅc63ƶ$XԇJAcәњ_W48w_D+5hSwcW_y[|W8<=u_I
R\(aYxD!~b;b,2?,ϐ#<CX扥oOKhSsg|
׳dX♲2=KXBcgKȞ1{,{y2g!K/,y._&Yovbճ@c1D%)4P*%><k ̠ GƐ?pDcw>.:Mh
:KYq~sJthJiIZ!,fP?7B(O"73ooAv&77g7KEF64ZV:Pf9ց9Ѓ;6)VXa ) d_g3R-v"uhC0DYadQB֍N$N%z>Oe e怑n,Oei`1X][WVdkLIR`8n0`?e7Uat1!
-F*b}ɉ86M@8Y#9oI}qr֣T{75
9.c@IsadNއe'`0Z8£PU:> ^7^s#U 5Do
l:kN`#C>~s.
&Nmb B!p߽7SR12U+XJ-0yg5Qx63j椴15lvB_X~hBml_V!g&P#>-.+ZČb:c+^=VqYQ_4Xqdr<:?Yw>