Date: Fri, 27 Nov 2009 16:19:38 -0500 From: Daniel Eischen <eischen@vigrid.com> To: Joe Marcus Clarke <marcus@freebsd.org> Cc: "threads@freebsd.org" <threads@freebsd.org> Subject: Re: [PATCH] Add missing pthread_condattr_{init, destroy} stubs to libc Message-ID: <4AF1E295-0524-4C39-94CD-9A12D574C64D@vigrid.com> In-Reply-To: <1259349248.1608.36.camel@shumai.marcuscom.com> References: <1259298918.1608.19.camel@shumai.marcuscom.com> <20091127131242.GA2368@deviant.kiev.zoral.com.ua> <1259349248.1608.36.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Nov 27, 2009, at 2:14 PM, Joe Marcus Clarke <marcus@freebsd.org> wrote: > On Fri, 2009-11-27 at 15:12 +0200, Kostik Belousov wrote: >> On Fri, Nov 27, 2009 at 12:15:18AM -0500, Joe Marcus Clarke wrote: >>> I would like permission to commit this patch which adds missing >>> pthread_condattr_{init,destroy} symbols to libc. I think I did the >>> symbol addition correctly (and it seems to work). Without this, the >>> weak symbols added in the libpthread-stubs port conflict with >>> those in >>> libthr, and applications with use these symbols can crash. >>> >>> I have temporarily hacked libpthread-stubs to fix this, but I really >>> feel these stubs should be added to libc. I've also copied kib as >>> he >>> has been kind enough to review my work in the past. Thanks. >>> >>> http://www.marcuscom.com/downloads/stubs.diff >> >> It is FBSD_1.2 version that we use for symbols added after HEAD >> become >> CURRENT-9. > > Done. I don't think the symbols belong in FBSD_1.2. They already exist in libthr in a previous namespace. If you use FBSD_1.2, then you probably need to bump them in libthr and libc_r, and add compatible symbols (no problem there since there are no differences) for the previous versions. Still not sure why libc needs all libpthread stubs. Shouldn't be necessary. -- DE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AF1E295-0524-4C39-94CD-9A12D574C64D>