Date: Mon, 12 Jul 2010 23:05:53 +0300 From: Alexander Motin <mav@FreeBSD.org> To: Mikolaj Golub <to.my.trociny@gmail.com>, freebsd-fs@freebsd.org Subject: Re: ata-disk.c:ad_init(): max_iosize might be uninitialized? Message-ID: <4C3B75A1.4020905@FreeBSD.org> In-Reply-To: <mailpost.1278963760.4818474.103.mailing.freebsd.fs@FreeBSD.cs.nctu.edu.tw> References: <mailpost.1278963760.4818474.103.mailing.freebsd.fs@FreeBSD.cs.nctu.edu.tw>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi. Mikolaj Golub wrote: > It might be a wrong list but I have not found freebsd-ata@ or freebsd-disk@ > list -). > > I just have looked accidentally at ad_init() in dev/ata/ata-disk.c and it > looks like there is at least theoretical possibility that atadev->max_iosize > remains uninitialized (if ata_controlcmd(ATA_SET_MULTI) fails). Shouldn't be > like in the patch below? It is not very obvious, but it is initialized in ata_add_child(). -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C3B75A1.4020905>