Date: Tue, 05 Oct 2010 10:47:00 -0400 From: jhell <jhell@DataIX.net> To: gordon@freebsd.org, FreeBSD Ports <ports@freebsd.org> Subject: devel/p4d/Makefile Message-ID: <4CAB3A64.4080709@DataIX.net>
next in thread | raw e-mail | index | archive | help
Hi Gordon,
I have just upgraded my p4d install and have found the following
inconsistency in the Makefile:
${CAT} pkg-message
pkg-message at this point cannot be found and it would be better if this
referred to the ports directory and the portname /pkg-message instead.
I might also suggest that instead of using touch(1) chown(1) chmod(1) to
create entries in the filesystem for the p4d.log that you use install(1)
instead as that allows you to achieve all three steps listed above in
one command like so.
install -S -o p4admin -g p4admin -m 640 /dev/null /var/log/p4d.log
And of course this might need/involve some checking to see if the users
log file already exists as we would not want to overwrite that by the
above command but nor do we want to blindly chmod(1) the file either
which is also done in the Makefile already.
Regards,
--
jhell,v
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CAB3A64.4080709>