Date: Sun, 29 Sep 2024 10:45:44 +0800 From: Zhenlei Huang <zlei@FreeBSD.org> To: Gary Jennejohn <garyj@gmx.de> Cc: Ian FREISLICH <ianfreislich@gmail.com>, FreeBSD Current <current@freebsd.org>, Kristof Provost <kp@FreeBSD.org> Subject: Re: Is INET6 a required option these days? (kernel build failure) Message-ID: <4E5CBF78-A9AC-4D1C-9D81-CB379C408468@FreeBSD.org> In-Reply-To: <20240927120714.35169c6c@ernst.home> References: <229d4fea-2eed-4710-99f8-f4f91ed539c0@gmail.com> <20240927120714.35169c6c@ernst.home>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Sep 27, 2024, at 6:07 PM, Gary Jennejohn <garyj@gmx.de> wrote: >=20 > On Thu, 26 Sep 2024 14:58:40 -0400 > Ian FREISLICH <ianfreislich@gmail.com> wrote: >=20 >> Lately there have been a couple of commits that fail to build because = v6 being compiled in despite INET6 being undefined. I think the latest = is 905db4aa88775865097714c170f4503da385747c. >>=20 >> /usr/src/sys/netpfil/pf/pf.c:8762:38: error: no member named 'icmp6' = in 'union pf_headers'; did you mean 'icmp'? >> 8762 | if (!pf_pull_hdr(m, *off, &pd->hdr.icmp6, = icmp_hlen, >>=20 >> Ian >>=20 >=20 > This happens now and then because most committers have INET6 enabled = and > they forget that INET6 is an option and not mandatory. Kristof is landing lots of commits from upstream ( OpenBSD ), so we need = be patient with him ... >=20 > I don't have INET6 enabled and have reported a number of problems in = the > source as a result of that. >=20 > In general it's pretty simple to fix these problems by merely adding > #ifdef INET6 ... #endif to the code. >=20 > -- > Gary Jennejohn >=20 Best regards, Zhenlei
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E5CBF78-A9AC-4D1C-9D81-CB379C408468>