Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Jun 2012 19:15:54 +0100
From:      Steven Chamberlain <steven@pyro.eu.org>
To:        freebsd-security@freebsd.org
Cc:        bz@freebsd.org, "Simon L. B. Nielsen" <simon@FreeBSD.org>
Subject:   Re: Update for FreeBSD Security Advisory FreeBSD-SA-12:04.sysret for 8.1
Message-ID:  <4FE0C1DA.2080809@pyro.eu.org>
In-Reply-To: <497105EC-3223-4E59-A6E6-F810A15BCA5C@FreeBSD.org>
References:  <497105EC-3223-4E59-A6E6-F810A15BCA5C@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi,

Thanks a lot of looking into this!

On 18/06/12 22:37, Simon L. B. Nielsen wrote:
> Note that this is ONLY for FreeBSD 8.1. Other branches are OK.

Having seen the correct fix now, I'm starting to wonder if the commit to
RELENG_7_4 was really okay too?

http://svnweb.freebsd.org/base/releng/7.4/sys/amd64/amd64/trap.c?annotate=236953#l975

The inserted code does not appear at the end of the function, like it
does now in all other versions including 8.1 which is the most similar.

I expect this would at least trap if the exploit was attempted, but then
it would omit the rest of the function, including userret();  would that
have consequences?

Thanks,
Regards,
-- 
Steven Chamberlain
steven@pyro.eu.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FE0C1DA.2080809>