Date: Sat, 10 Aug 2002 23:26:51 -0400 From: Mike Tancsa <mike@sentex.net> To: Ian Dowse <iedowse@maths.tcd.ie> Cc: stable@freebsd.org, luigi@freebsd.org Subject: Re: fxp problems with latest stable Re: panics after upgrading to -STABLE Aug 9, 2002 (still something up) Message-ID: <5.1.0.14.0.20020810225848.068a4690@192.168.0.12> In-Reply-To: <200208110304.aa47521@salmon.maths.tcd.ie> References: <Your message of "Sat, 10 Aug 2002 21:18:57 EDT." <5.1.0.14.0.20020810210400.0622d770@192.168.0.12>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Ian,
Sorry, my last post was not as complete as it should be. The patch
does seem to make a difference. I have 2 non production machines I can
play with now to help track this down. The one production box I cant play
with just yet, but suffice to say, it seems to be very happy with the
previous rev of the driver.
To make sure I was doing it right, I did it on 2 test machines and repeated
the process a couple of times.
Also, the pings less lossy with your patch. Note, these are non busy
machines (PIII 1000 and PIV1.6). The patch does seem to make the problem
less acute. But, it is still there.
ping -q -i .05 192.168.43.218
PING 192.168.43.218 (192.168.43.218): 56 data bytes
^C
--- 192.168.43.218 ping statistics ---
3803 packets transmitted, 3341 packets received, 12% packet loss
round-trip min/avg/max/stddev = 0.119/0.130/0.477/0.016 ms
Note, to my production box which is cvsup as of late this afternoon EDT
time, BUT with the previous version of the driver,
ping -q -c 1000 -i .05 backup2
--- backup2.sentex.ca ping statistics ---
1000 packets transmitted, 1000 packets received, 0% packet loss
round-trip min/avg/max/stddev = 0.313/0.326/0.622/0.014 ms
hw.fxp_rnr is 0 on both of my test machines. (The mib is not there now on
my production box).
---Mike
At 03:04 AM 8/11/2002 +0100, Ian Dowse wrote:
>Index: if_fxp.c
>===================================================================
>RCS file: /home/iedowse/CVS/src/sys/dev/fxp/if_fxp.c,v
>retrieving revision 1.110.2.24
>diff -u -r1.110.2.24 if_fxp.c
>--- if_fxp.c 9 Aug 2002 02:04:20 -0000 1.110.2.24
>+++ if_fxp.c 11 Aug 2002 01:46:23 -0000
>@@ -1292,7 +1292,9 @@
> * info will be used in the subsequent polling cycle.
> */
>
>+#if 0
> #define FXP_RFA_RNRMARK 0x4000 /* used to mark a pending
> RNR intr */
>+#endif
>
> for (;;) {
> m = sc->rfa_headm;
>@@ -1307,8 +1309,10 @@
> if ( (rfa->rfa_status & FXP_RFA_STATUS_C) == 0)
> break;
>
>+#if 0
> if (rfa->rfa_status & FXP_RFA_RNRMARK)
> rnr = 1;
>+#endif
> /*
> * Remove first packet from the chain.
> */
>@@ -1342,15 +1346,19 @@
> }
> }
> if (rnr) {
>+#if 0
> if (rfa->rfa_status & FXP_RFA_STATUS_C)
> rfa->rfa_status |= FXP_RFA_RNRMARK;
> else {
>+#endif
> fxp_scb_wait(sc);
> CSR_WRITE_4(sc, FXP_CSR_SCB_GENERAL,
> vtophys(sc->rfa_headm->m_ext.ext_buf) +
> RFA_ALIGNMENT_FUDGE);
> fxp_scb_cmd(sc, FXP_SCB_COMMAND_RU_START);
>+#if 0
> }
>+#endif
> }
> }
>
--------------------------------------------------------------------
Mike Tancsa, tel +1 519 651 3400
Sentex Communications, mike@sentex.net
Providing Internet since 1994 www.sentex.net
Cambridge, Ontario Canada www.sentex.net/mike
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5.1.0.14.0.20020810225848.068a4690>