Date: Tue, 08 Aug 2006 00:24:49 +0400 From: Boris Samorodov <bsam@ipt.ru> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: freebsd-ports@freebsd.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: extract both bz2 and gz files from distfiles Message-ID: <50488990@bsam.ru> In-Reply-To: <20060807201203.GA84762@lor.one-eyed-alien.net> (Brooks Davis's message of "Mon, 7 Aug 2006 15:12:03 -0500") References: <14817321@bsam.ru> <20060807183724.GA47899@xor.obsecurity.org> <16560673@bsam.ru> <20060807201203.GA84762@lor.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 7 Aug 2006 15:12:03 -0500 Brooks Davis wrote:
> On Mon, Aug 07, 2006 at 11:56:46PM +0400, Boris Samorodov wrote:
> > On Mon, 7 Aug 2006 14:37:25 -0400 Kris Kennaway wrote:
> > > On Mon, Aug 07, 2006 at 03:12:06AM +0400, Boris Samorodov wrote:
> >
> > > > We have got a port (lang/gnat-gcc34) which has both bz2 and gz
> > > > distfiles. As for 5.x+ extracting is gone automagically. But not at
> > > > 4.x. Well, at 4.x extracting may be done for example, by using
> > > > USE_BZIP2 knob and doing gunzipping at after-extract:.
> > > >
> > > > Does someone know a better solution?
> > > > Does we have examples at our ports?
> >
> > > Use a do-extract that extracts all distfiles or EXTRACT_ONLY with
> > > post-extract that extracts the other ones.
> >
> > Thanks, Kris. I'm trying to test (actually, to find an 4.x system)
> > some broken ports with a patch(es) which includes (thanks Brooks):
> > -----
> > .if ${OSVERSION} < 500000
> > EXTRACT_DEPENDS+= bsdtar:${PORTSDIR}/archivers/libarchive
> > TAR= /usr/local/bin/bsdtar
> > .endif
> > -----
> >
> > To me that seems a good solution.
> I'd suggest using not using an absolute path in the TAR definition
> since the dependency check doesn't and using 502111 as the version since
> that's the first version bump after the initial bsdtar import. Not that
> we really need to worry about such early 5.x release, but it's more
> correct.
Thanks again, Brooks. The patch will include (if Kris won't complain):
-----
.if ${OSVERSION} < 502111
EXTRACT_DEPENDS+= bsdtar:${PORTSDIR}/archivers/libarchive
TAR= bsdtar
.endif
-----
WBR
--
Boris Samorodov (bsam)
Research Engineer, http://www.ipt.ru Telephone & Internet SP
FreeBSD committer, http://www.FreeBSD.org The Power To Serve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50488990>