Date: Fri, 08 Feb 2013 00:50:31 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Dewayne Geraghty <dewayne.geraghty@heuristicsystems.com.au> Cc: ports@FreeBSD.org, Brooks Davis <brooks@freebsd.org>, Bryan Drewery <bdrewery@FreeBSD.org> Subject: Re: openssh-portable segmentation faults Message-ID: <51143DC7.7070902@FreeBSD.org> In-Reply-To: <511435D8.8000900@FreeBSD.org> References: <67A39057348F4D1BA43004DB5F0E8DBB@white> <5113B343.303@FreeBSD.org> <CD64A9A7097A415CB05541C9032576D1@white> <511435D8.8000900@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------040008010600050902050706
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
On 2013-02-08 00:16, Dimitry Andric wrote:
> On 2013-02-07 22:14, Dewayne Geraghty wrote:
> ...
>> Bryan, Dimitry,
>> Thank-you for your interest.
>> Unfortunately we have no debugging tools on any of the machines. I'll build one today and reproduce.
...
> Executive summary: we recently imported a strnvis() implementation from
> NetBSD, which has differently ordered arguments from the strnvis()
> implementation in OpenBSD. When OpenSSH calls it with arguments ordered
> in the way OpenBSD expects, the function segfaults.
And here is a patch, which works for me. It simply disables use of
libc's strnvis(), forcing the port to use its own bundled version.
--------------040008010600050902050706
Content-Type: text/x-diff;
name="security__openssh-portable-1.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="security__openssh-portable-1.diff"
Index: security/openssh-portable/Makefile
===================================================================
--- security/openssh-portable/Makefile (revision 311824)
+++ security/openssh-portable/Makefile (working copy)
@@ -25,6 +25,7 @@ CONFLICTS?= openssh-3.* ssh-1.* ssh2-3.*
USE_PERL5_BUILD= yes
USE_OPENSSL= yes
GNU_CONFIGURE= yes
+CONFIGURE_ENV= ac_cv_func_strnvis=no
CONFIGURE_ARGS= --prefix=${PREFIX} --with-md5-passwords \
--without-zlib-version-check --with-ssl-engine
PRECIOUS= ssh_config sshd_config ssh_host_key ssh_host_key.pub \
--------------040008010600050902050706--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51143DC7.7070902>