Date: Sat, 13 Jul 2013 09:54:03 +0100 From: Frank Leonhardt <frank2@fjl.co.uk> To: freebsd-questions@freebsd.org Subject: Re: jls usage Message-ID: <51E115AB.6030004@fjl.co.uk> In-Reply-To: <51E0D3C9.3020505@ShaneWare.Biz> References: <51DF59B1.4020107@a1poweruser.com> <13CA24D6AB415D428143D44749F57D7201FBF9CF@ltcfiswmsgmb21> <51DFCDD2.2010104@fjl.co.uk> <13CA24D6AB415D428143D44749F57D7201FC19A4@ltcfiswmsgmb21> <51E01A22.7030306@fjl.co.uk> <51E021AA.5030905@fjl.co.uk> <51E02729.7070203@fjl.co.uk> <51E0D3C9.3020505@ShaneWare.Biz>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13/07/2013 05:12, Shane Ambler wrote:
> On 13/07/2013 01:26, Frank Leonhardt wrote:
>
>> Okay - answering my own question and solved... It's a bug (or is that a
>> feature?).
>>
>> In /etc/rc.d/jail line 647 it currently reads:
>>
>> eval ${_setfib} jail ${_flags} -i ${_rootdir}
>> ${_hostname} \
>> \"${_addrl}\" ${_exec_start} > ${_tmp_jail}
>> 2>&1 \
>> </dev/null
>>
>> And it should (IMHO) read:
>>
>> eval ${_setfib} jail ${_flags} -n ${_jail} -i
>> ${_rootdir} ${_hostname} \
>> \"${_addrl}\" ${_exec_start} > ${_tmp_jail}
>> 2>&1 \
>> </dev/null
>>
>> Once changed, everything works find and your jails are named as per the
>> rc.conf file definitions. Can anyone think of a reason for NOT fixing
>> this?
>
>
> Go with bug ;-) - fix (improvement?) is working it's way through.
>
> You mentioned running 8.2 so I wondered if it has changed.
>
> If you look through the source tree you will find in 8.4 that line has
> the -n ${_jail} addition plus some other extras.
>
> Looks like it showed up in stable/8 at r242083 as part of a larger
> improvement.
>
Yeah, I spotted that but only after I put in a change request :-(
Someone did exactly the same change last July but it wasn't a PR. It's
in head (revision 238102) and I suspect it's now in 9.1.
Next question: How do you kill a PR you've changed your mind about?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51E115AB.6030004>