Date: Thu, 02 Oct 2014 20:35:25 +0200 From: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= <dumbbell@FreeBSD.org> To: svn-src-all@freebsd.org, Hiroki Sato <hrs@FreeBSD.org> Subject: Re: svn commit: r272386 - in head: sbin/ifconfig share/man/man4 sys/net Message-ID: <542D9AED.6060805@FreeBSD.org> In-Reply-To: <201410012137.s91LbXL4025967@svn.freebsd.org> References: <201410012137.s91LbXL4025967@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --INET5QpKHcGqpMp81aEvCN60libwLEbqG Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > Author: hrs > Date: Wed Oct 1 21:37:32 2014 > New Revision: 272386 > URL: https://svnweb.freebsd.org/changeset/base/272386 >=20 > Log: > Virtualize lagg(4) cloner. This change fixes a panic when tearing do= wn > if_lagg(4) interfaces which were cloned in a vnet jail. Hi! I believe this change needs at least an entry in UPDATING, because an ifconfig(8) binary built before this commit fails to change laggproto on a kernel including this commit. The error is the following: # ifconfig lagg0 laggproto failover ifconfig: SIOCSLAGG: Invalid argument By quickly looking at the code, I would say that the culprit is the change in size of the "struct lag_reqall". The new "ra_opts" field in "struct lagg_reqall" isn't initialized in the incompatible ifconfig(8) binary. This could be considered invalid options, leading to "error =3D EINVAL" in if_lagg.c:1301. Another non-critical regression is that this ifconfig(8) binary doesn't display the laggproto and laggport lines. I mean those lines: # ifconfig lagg0 lagg0: flags=3D8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> (...) (...) laggproto failover lagghash l2,l3,l4 laggport: wlan0 flags=3D0<> laggport: re0 flags=3D5<MASTER,ACTIVE> Beside an UPDATING entry, how about a previously released world with this new kernel? Isn't this configuration supposed to work? --=20 Jean-S=C3=A9bastien P=C3=A9dron --INET5QpKHcGqpMp81aEvCN60libwLEbqG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJULZrxXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NzA4N0ZEMUFFQUUwRTEyREJDNkE2RjAz OUU5OTc2MUE1RkQ5NENDAAoJEDnpl2Gl/ZTMYVQP/0PPlnZusCHDst/k/zPqo31/ IdwUeUZWZWKXWQPWu2Ae/XSVysB683M0oasDFq/exalh7un70gBI+U0Pxr3xfzaR 323ZpX1X48guGKK1U6Do2wAPGCmhL1TXqyAnhlIdNVACEHuy3yTj+UIyrjwBDFVS tJ4PG3BK7PVLdOaWSFbqFDETmkqqO9xV2Kz+wQVT+gRBUUYeriA/0tGushfS9K2k ShDDIR7Gf7ik4b5ubKluHpYU6EkSOXeO+losjqR/pDNVbyp3QI3Y08we5BKaev2D MLfnjd5Gvuou3FKF5s3FXXdYRmA0+9vihRgTBfm9LEchUtk/UcSFYCWSg76D+6MC oTbuYK92Q4krGyl3PGtvHnIamndBP5vmiAMtPKS9tDZaXFIFJDnrUFg8nc14rOA/ 1bPQsJMSMqRZrvZ4rcLu8VWFo5kE/0QHaZpcRHApfgdfOzo+n0z4BwJJAr45Ueia tZHmmZq6bitdjLtuwVVTQkrOzi65AvsgagI3mqzTU9rAgzQfnWkrQmPV6CMJLaVx KGLUPLbtUGgTvXJVyoHUQ/skXDJ8YcCd3AmNcruQjiHD6CMw/N9h6/8zKzorq3QH OphOKF22GQPIigt1YnZ/eiJhSGCfT6Eyz+fYt9ZH9Wt2e//cnTIECPhV7UUrqxsm 7u5aO/kHSKHdas+nYSzj =195E -----END PGP SIGNATURE----- --INET5QpKHcGqpMp81aEvCN60libwLEbqG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?542D9AED.6060805>