Date: Wed, 12 Nov 2014 18:36:06 -0600 From: Bryan Drewery <bdrewery@FreeBSD.org> To: John-Mark Gurney <jmg@funkthat.com>, ports@FreeBSD.org Subject: Re: review of new tcpcrypt port... Message-ID: <5463FCF6.4040901@FreeBSD.org> In-Reply-To: <20141113001649.GB24601@funkthat.com> References: <20141108100709.GF24601@funkthat.com> <20141113001649.GB24601@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 11/12/2014 6:16 PM, John-Mark Gurney wrote: > John-Mark Gurney wrote this message on Sat, Nov 08, 2014 at 02:07 -0800: >> I'd like someone to review the attached port for me to commit... It >> contains a daemon to run on divert sockets to implement the tcpcrypt >> protocol. I have tested this port w/ HEAD and it works fine w/ the >> attached patch... >> >> The included patch has been submitted upstream and committed, but a >> new release has not yet been released. >> >> portlint -A looks fine. > > As I haven't received a review, in a couple more days, probably Friday, > I'll commit the port... > > Thanks. > Can you include the security/Makefile bit in the patch too please? Have you ran it through poudriere? At the very least 'env DEVELOPER=1 make stage' and 'make check-plist' are required. Portlint is not sufficient, nor can it even be trusted in all cases. If you check those and get back to me I'll approve it. Usually you'd need a port commit bit to commit anything, or an approval (which is different than a review). I hate our process, but that's how it is. Poke people in #bsdports on EFNet, or me on IRC, for approvals/reviews in the future. -- Regards, Bryan Drewery [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJUY/z2AAoJEDXXcbtuRpfP8GMH/jstXWoO9F9jZPGMUt1zSS9m gqLfMbbBnEGImTFyYipLpup/GET7qm7AQzdvrwFFcUZ6h7RXn4Ih6J+B3HaRA61w wKtuOQOGuaBirUDSOSZ7YXA5mUyCV+1MVhzC/9iiHo/nKZB3VB7m8XlpUcrYwjrO 22aj76i9mgiwi+Z4LUqf07ScQHZELBb1cbqX4idU/+NyKqQbSS+TI54JeMa90aW4 dHV7mEPp8g3UyO9Bh3Rwd0LEjkbBw8CsVt5Y2Y/bOgh76nZjb0QFzSVWebH7utS4 rTSx+AVoxe508FJnAruJmhcLYQFlBSWe/d9ZlYXCZXYBN6x9uvmymqFEJBufMdY= =yGvT -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5463FCF6.4040901>