Date: Thu, 15 Jan 2015 01:59:57 -0500 From: Allan Jude <allanjude@freebsd.org> To: freebsd-hackers@freebsd.org Subject: Re: [PATCH] Display progress during getmemsize() so the kernel doesn't look like it hanged Message-ID: <54B7656D.9000704@freebsd.org> In-Reply-To: <D0DCA0FF.129C55%rpokala@panasas.com> References: <D0DCA0FF.129C55%rpokala@panasas.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RUdiQ49dWmj5EqVT5SVT5fJPCNA76Lles Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2015-01-15 01:54, Pokala, Ravi wrote: > -----Original Message----- >> Date: Tue, 13 Jan 2015 13:53:19 -0500 >> From: John Baldwin <jhb@freebsd.org> >> To: Eric van Gyzen <eric@vangyzen.net>, Lars Engels >> <lars.engels@0x20.net>, Allan Jude <allanjude@freebsd.org> >> Cc: freebsd-hackers@freebsd.org >> Subject: Re: [PATCH] Display progress during getmemsize() so the >> kernel doesn't look like it hanged >> Message-ID: <3221643.2Qu3vC2WD5@ralph.baldwin.cx> >> Content-Type: text/plain; charset=3D"us-ascii" >> >> On 1/13/15 10:48 AM, Eric van Gyzen wrote: >>> On 01/13/2015 04:11, Lars Engels wrote: >>>> On Mon, Jan 12, 2015 at 12:27:18AM -0500, Allan Jude wrote: >>>>> Is this feature still useful with memtest.tests=3D0? >>>> This feature is useful for everyone who has it set to 1, if they kno= w >>>> about it or not. So it's a very useful feature. >>> >>> Agreed. >>> >>> Comments on the patch: >>> >>> The patch will divide by zero when PAGE_SIZE > 1 MiB. Maybe remove >>> PAGES_PER_MB, and just use PAGES_PER_GB. Make it const, too. >>> >>> The "total" line is mostly redundant with the later messages regardin= g >>> "real memory" and "avail memory". I suggest removing it. >> >> I agree with these. One other nit is that FreeBSD tends to use all ca= ps >> for a macro rather than variables. Ravi, how about this variant, it >> also only displays the dots if the memory test is enabled. Also, I >> think the commit to disable the test should probably be merged to 10, = yes. >=20 > We have a winner. I regenerated the patch against 10-STABLE and attache= d > it to the PR. Thanks all! >=20 > -Ravi >=20 > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.o= rg" >=20 Glad to see this, thanks for doing the work Ravi. Also, I agree with jhb@, we should disable the test by default in stable/10 (i think it is off by default only for VMs currently). --=20 Allan Jude --RUdiQ49dWmj5EqVT5SVT5fJPCNA76Lles Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJUt2VwAAoJEJrBFpNRJZKfgXkP/AjxiYbrQHCdsC9cBxQCCgm3 ozxqkOhBg3A8Kc2HyCI00pXe2+sbJ7sPBUSy+eNuDhjj9zkQkOTZNe51qYyA3/cr GpVs9wuKa/goz45ExWR/aIt85wZdGMLCEwivvVNarxbbGccUQxI80obaGS7yKcn+ OHNM8uDxbAjibteABUfcapDaoXYL7Up14G+6MvZ3ImISIbJ8dddcd4PXwEPpfr83 Qwbmyf8HzPpCqG8OIq8jFm2fZMb9t0jl95cSul1UMX50a2l5lWBIlk8l6ccKR0yS 6898/MtYJNMEgv40KTJw7PZMC/ij0aLEIDpMgLQn8PzkF5EdqcpjNZZjVxO3Xnq8 ply/2QhuMuJb1DLPDF/gLJ2E9QIJcdHUpfQP9YDVFXl9SwM4Lu9R2PhAv5x5Zw+a /dA0CJvPdQW6PacJuU/ne1b9UF2vZdv5lFJXm4j7YyTTAF7bpOBbWdeMsxQf/8FI LpEeO6F5ggPNTsVPvEwzaCdcPycM9ateNsRuGogP5/FZoExOFCLSg8987Gbq+qZd peDnkqmd0xuIbtICdKX/o1prruTJhkaktDuS/VbaGsccut+1kVvbyBZ+g7wVpXG5 WoCjvSpYfAxu9fzyyLUPfriVZdvP7PlaJvCM12aIxl9jP/afnx8KolaWkAoXVj83 HJkLTm1wLN6Rl4ZYMcjm =XFqR -----END PGP SIGNATURE----- --RUdiQ49dWmj5EqVT5SVT5fJPCNA76Lles--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54B7656D.9000704>