Date: Wed, 04 Mar 2015 17:45:58 +1100 From: Kubilay Kocak <koobs@FreeBSD.org> To: Doug Hardie <bc979@lafn.org> Cc: "bugmeister@freebsd.org" <bugmeister@FreeBSD.org>, freebsd-ports@freebsd.org, Bryan Drewery <bdrewery@FreeBSD.org> Subject: Re: Approving a patch Message-ID: <54F6AA26.1080404@FreeBSD.org> In-Reply-To: <54F6155C.3010405@FreeBSD.org> References: <93878D88-4F1E-41EF-B99B-0B70119DDE0C@lafn.org> <54F6155C.3010405@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/03/2015 7:11 AM, Bryan Drewery wrote: > On 3/3/2015 1:53 PM, Doug Hardie wrote: >> I am the maintainer for a port. I received a suggested patch for the port that is good. There used to be a link in the notification email to click on to approve the patch. With the new port system, that is gone (or at least I didn’t find it). I went through the porters manual and didn’t find anything on how to approve a patch. How do I do that? >> > > In bugzilla there is a maintainer feedback dropdown. You can change it > to a '+' and also leave a comment saying approved. > > Canonically and preferred: Set maintainer-approval flag to + *on the attachment/patch*. The maintainer-feedback flag is at the issue/bug scope, not the attachment/patch scope. This of course requires the maintainer-approval flag was set to ? with your email as the value first. Currently this is not automatic, but *should be* if there is an attachment of type: patch in the issue. I'll create an issue for that now for bugmeister@ to look into addressing. Only in cases where maintainer-approval is *not* already set to"?", is using the maintainer-feedback flag + comment flow OK. Setting maintainer-feedback is ambiguous, and is used to prove 'acknowledgement' of an issue or question. This is especially the case when there are multiple version of patches, or patches from multiple contributors. In future it will be used to derive "maintainer timeouts" to kick issues along, and open them up for someone else to make a decision on. tldr; Set the maintainer-approval flag to + -- Regards, Kubilay Bugmeister
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54F6AA26.1080404>