Date: Sat, 14 Sep 2013 20:42:13 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Ian Lepore <ian@freebsd.org> Cc: freebsd-current@FreeBSD.org Subject: Re: aicasm build error Message-ID: <55AEA8C2-9C47-4AB4-8626-EB7AC28839FC@FreeBSD.org> In-Reply-To: <1379181005.1197.24.camel@revolution.hippie.lan> References: <1379181005.1197.24.camel@revolution.hippie.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_15C3E84C-61CC-4712-BD19-0E73B49E020B Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On Sep 14, 2013, at 19:50, Ian Lepore <ian@freebsd.org> wrote: > For a while I've been getting a build error on aicasm during the early > steps of the build. Today I finally dug into it and discovered it's > because the build is using a mix of header files, some from /usr/include > on the build host, and some from obj/... for the target being built. It > happens because dev/aic7xxx/aicasm/Makefile contains CFLAGS+= -I. and > the current directory when aicasm builds is obj/.../<kernconf>. In my > case it was picking up machine/_types.h from objdir. > > Apparently this is usually harmless, but if the build host system and > the target versions are far enough apart, or with a cross-build where > the host and target are different architectures, you can get problems. > > After a little digging, I just now discovered Marcel fixed this long ago > in r70000, but then it got undone in r236578 a couple months ago. Is > there any reason not to restore Marcel's fix, such as with the attached > patch? It got undone for a specific reason, which is mentioned in the commit message for r236578. This hack might make it work, but it might also cause other issues. The problem really is how to make sure aicasm is compiled with the *host* compiler, not the compiler from /usr/obj. -Dimitry --Apple-Mail=_15C3E84C-61CC-4712-BD19-0E73B49E020B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) iEYEARECAAYFAlI0rgwACgkQsF6jCi4glqOcbgCgxIQwk9YlnclN4lhavyBOzvrw 28wAoN5vIIqbBoNr9xG5sV8hOJlEPvCl =pS0u -----END PGP SIGNATURE----- --Apple-Mail=_15C3E84C-61CC-4712-BD19-0E73B49E020B--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55AEA8C2-9C47-4AB4-8626-EB7AC28839FC>