Date: Sun, 2 Mar 2014 14:54:52 -0800 From: Garrett Cooper <yanegomi@gmail.com> To: Julio Merino <jmmv@freebsd.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, Pawel Jakub Dawidek <pjd@freebsd.org> Subject: Re: [PATCH] Integrate pjdfstest into the build Message-ID: <56D809A7-5387-475A-8C89-794E328F6935@gmail.com> In-Reply-To: <CAFY7cWDsR=82ANK8q2-SoVyu6BowdC6hHDwo%2Bs1P7Jt%2Bfy8ZCQ@mail.gmail.com> References: <94D3F60A-1E12-418B-8313-E43C93878B95@gmail.com> <CAFY7cWDsR=82ANK8q2-SoVyu6BowdC6hHDwo%2Bs1P7Jt%2Bfy8ZCQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mar 2, 2014, at 1:31 PM, Julio Merino <jmmv@freebsd.org> wrote: > On Mon, Jan 27, 2014 at 5:41 AM, Garrett Cooper <yanegomi@gmail.com> = wrote: >> Hi all, >> The attached patch integrates pjdfstest into the build. It = also simplifies some logic in tests/sys/Makefile when copying Kyuafile. >=20 > Aaand one more time, apologies for the delay. I think I'm caught up = now! >=20 > * What's the point of PJDFSTEST_I_KNOW_WHAT_I_AM_DOING? *Why* is it a > very bad idea to do so? It=92s a safety belt. I=92ve run into cases where interrupted test runs fill up filesystems = with data (either free space or inodes). Depending on what method you = use to clean up the contents of directories, it can take ages to delete = all of the files (rm -rf for instance is a very linear operation, but = parallel rm -rf=92s are considerably quicker). I=92ll add a comment to = this effect. > * The 'tests' path component in pjdfstest/tests/ should go away; it is > redundant. It=92s not redundant; it=92s needed for the conf file: # make all =3D=3D=3D> pjdfstest (all) =3D=3D=3D> tests (all) make[1]: don't know how to make conf. Stop make[1]: stopped in /usr/src/tests/sys/pjdfstest/tests *** Error code 2 Stop. make: stopped in /usr/src/tests/sys/pjdfstest # git checkout -- tests/Makefile=20 =85 # echo $? 0 > * Add $FreeBSD$ tags everywhere where missing. I=92ll add those. > * The test files should move from tools/regression/pjdfstest/ into the > new location under tests/sys/ and be renamed to follow the conventions > under src/test (e.g. xx.t -> xx_test). Please talk to Pawel about this. These tests have been developed and are = maintained (to some degree) outside FreeBSD: = https://github.com/pjd/pjdfstest . I=92d rather treat this as an = integration of the 3rd party package, not a refactor. If you want me to = install the tests like _test though, I=92d be more than happy to do = that. Thank you :)! -Garrett=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56D809A7-5387-475A-8C89-794E328F6935>