Date: 04 Nov 1996 21:42:26 +0000 From: Paul Richards <p.richards@elsevier.co.uk> To: "Andrey A. Chernov" <ache@freefall.freebsd.org> Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-ports@freefall.freebsd.org Subject: Re: cvs commit: ports/www/apache/patches patch-ag patch-ac Message-ID: <57683lpmf1.fsf@tees.elsevier.co.uk> In-Reply-To: "Andrey A. Chernov"'s message of Sun, 3 Nov 1996 20:32:53 -0800 (PST) References: <199611040432.UAA10730@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
"Andrey A. Chernov" <ache@freefall.freebsd.org> writes: > ache 96/11/03 20:32:51 > > Modified: www/apache/patches patch-ac > Added: www/apache/patches patch-ag > Log: > Situation: > It is impossible to suppress initial HTML preamble for directories, i.e. > <HEAD><TITLE>Index of dir</TITLE></HEAD><BODY> > It means that it is impossible to change <TITLE> or add any > <META HTTP-EQUIV...> tags to <HEAD> section or change <BODY> > attributes without HTML syntax violation (.asis, cern_meta, etc. > not helps here too). > > Fix: > I add "SuppressHTMLPreamble" option to "IndexOptions". When this option > is set _and_ HEADER.html (or what you set as it) is present and readable, > standard <HEAD><TITLE>Index of dir</TITLE></HEAD><BODY> preamble > will be suppressed assuming you have right HTML preamble in your > HEADER.html. It solves all problems mentioned above. > > Revision Changes Path > 1.5 +1 -1 ports/www/apache/patches/patch-ac Hmm, wearing my Apache hat rather than my FreeBSD hat I've got to say that I'm not very happy with this patch. This makes "FreeBSD/Apache" incompatible with standard Apache since it has added configuration options that Apache doesn't have and I don't think we'll be very happy over in the Apache lists when we get support questions about the "SuppressHTMLPreamble" option. You're going to get a seriously bad name if FreeBSD applied patches create bugs that weren't present in the original. If you want to make changes like this then submit them to the Apache team rather than embark on a FreeBSD/Apache. If you insist on doing this then change the version string so this server is clearly marked as being the FreeBSD enhanced version of Apache and then expect any bug reports to be sent your way. These types of changes aren't "porting" patches and as such I don't think they should be part of the ports structure. Like I said, if you're interested in Apache development join the Apache development list. -- Paul Richards. Originative Solutions Ltd. (Netcraft Ltd. contractor) Elsevier Science TIS online journal project. Email: p.richards@elsevier.co.uk Phone: 0370 462071 (Mobile), +44 (0)1865 843155
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57683lpmf1.fsf>