Date: Thu, 28 Jun 2012 21:45:17 -0700 From: Tim Kientzle <kientzle@freebsd.org> To: Warner Losh <wlosh@bsdimp.com> Cc: arm@freebsd.org Subject: Re: Naming mess... Message-ID: <576FE101-93B7-46D6-B38D-A28EF18CFFC2@freebsd.org> In-Reply-To: <3AB368CC-BE8B-4058-A342-763B8C073800@bsdimp.com> References: <FB2E340B-34DD-4CBC-B539-6996E79F37E3@freebsd.org> <1340921715.1110.100.camel@revolution.hippie.lan> <3AB368CC-BE8B-4058-A342-763B8C073800@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jun 28, 2012, at 3:31 PM, Warner Losh wrote:
> On Jun 28, 2012, at 4:15 PM, Ian Lepore wrote:
> On Tue, 2012-06-26 at 22:21 -0700, Tim Kientzle wrote:
>>>=20
>>> Here's what I would like to do:
>>>=20
>>> * The first is a given and we should leave it alone. The patches =
I'm cleaning up make this useful in the armv6 tree.
>>>=20
>>> * The second I would like to move out of asm.h so it can be used in =
C code. I would like to rename it to _HAVE_ARMv6_INSTRUCTIONS, which I =
think is clearer. I have renamed it in my patches but not yet moved it =
to another header. Suggestions appreciated.
>>>=20
>>> "NEED_ARM_ARCH_6_SUPPORT" * Someday, I would like to rename the =
third one, though I don't have a concrete proposal yet. =
("NEED_ARM_ARCH_6_SUPPORT" is expressive but wordy; better suggestions =
appreciated.)
>>>=20
>>> Cheers,
>>>=20
>>> Tim
>>>=20
>>> [0] This page has a nice table: =
https://wiki.edubuntu.org/ARM/Thumb2PortingHowto
>>>=20
>>=20
>> I'm not working with armv6 stuff yet, but I like all of what you
>> propose. I can't help but note that NEED_ARM_ARCH_6_SUPPORT is =
actually
>> shorter than _HAVE_ARMv6_INSTRUCTIONS. If it's just too wordy, maybe
>> the "NEED_" part could be left off. =20
>=20
> #define ARM_ARCH 6
>=20
> #if ARM_ARCH >=3D 6
> ...
> #endif
>=20
> Might not be the worst idea...
I don't think ARM ISA versions are completely
well ordered. I seem to recall seeing a few cases
where "later" processors have dropped instructions
that were present in "earlier" processors.
Tim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?576FE101-93B7-46D6-B38D-A28EF18CFFC2>