Date: Tue, 30 Nov 2010 03:33:27 -0600 From: Ade Lovett <ade@FreeBSD.org> To: Mark Linimon <linimon@lonesome.com> Cc: FreeBSD Ports <ports@FreeBSD.org> Subject: Re: CFR: patch to cleanup usage of SRC_BASE in various ports Message-ID: <5A25461F-A28C-415C-A8AB-59C91E1B1CC7@FreeBSD.org> In-Reply-To: <20101130041323.GA17404@lonesome.com> References: <20101130041323.GA17404@lonesome.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Nov 29, 2010, at 22:13 , Mark Linimon wrote: > I would appreciate feedback on the following patch: >=20 > http://people.freebsd.org/~linimon/patches/diff.out.srcbase Seems like there's an awful lot of duplication of: SRC_BASE?=3D /usr/src in those port Makefiles. What's wrong with adding the above, with a bit of documentation, to = bsd.port.mk ? This also allows portlint to be trivially extended to warn/fatal on = seeing /usr/src in any port Makefile, pointing the author in the = direction of ${SRC_BASE} -aDe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5A25461F-A28C-415C-A8AB-59C91E1B1CC7>