Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 15 Nov 2019 22:19:33 -0600
From:      Alan Cox <alc@rice.edu>
To:        bob prohaska <fbsd@www.zefox.net>
Cc:        freebsd-arm@freebsd.org
Subject:   Re: "Invalid ASID" Patch
Message-ID:  <5b390364-3a33-cc8e-ff88-a8b415510120@rice.edu>
In-Reply-To: <20191116035936.GA80744@www.zefox.net>
References:  <3ef09b7e-f7cf-bb10-1a14-a01b0c86b486@rice.edu> <20191116035936.GA80744@www.zefox.net>

next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------78A81C0804880BD9F12E9B3F
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

On 11/15/19 9:59 PM, bob prohaska wrote:
> On Fri, Nov 15, 2019 at 12:53:46PM -0600, Alan Cox wrote:
>> A patch for the recent "Invalid ASID" assertion failure can be found at
>> https://reviews.freebsd.org/D22388
>>
> The website reports
> "This revision is now accepted and ready to land".
>
> Could someone please translate?
>
> Thanks for reading,
>
> bob prohaska
>
That just means that the patch has received a positive review.

I've attached the patch to this email.  Apply it to your source tree, 
recompile and reinstall a new kernel, and then retry your "buildworld".



--------------78A81C0804880BD9F12E9B3F
Content-Type: text/x-patch; charset=UTF-8;
 name="arm64_pmap_remove_all.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="arm64_pmap_remove_all.patch"

Index: arm64/arm64/pmap.c
===================================================================
--- arm64/arm64/pmap.c	(revision 354585)
+++ arm64/arm64/pmap.c	(working copy)
@@ -2879,11 +2879,12 @@ retry:
 
 		pte = pmap_l2_to_l3(pde, pv->pv_va);
 		tpte = pmap_load_clear(pte);
-		pmap_invalidate_page(pmap, pv->pv_va);
 		if (tpte & ATTR_SW_WIRED)
 			pmap->pm_stats.wired_count--;
-		if ((tpte & ATTR_AF) != 0)
+		if ((tpte & ATTR_AF) != 0) {
+			pmap_invalidate_page(pmap, pv->pv_va);
 			vm_page_aflag_set(m, PGA_REFERENCED);
+		}
 
 		/*
 		 * Update the vm_page_t clean and reference bits.

--------------78A81C0804880BD9F12E9B3F--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5b390364-3a33-cc8e-ff88-a8b415510120>