Date: Sun, 6 Apr 2003 22:48:53 +0200 (MEST) From: Markus Dolze <sm4tnp8@gmx.net> To: freebsd-isdn@freebsd.org Subject: Re: bugs in isdnmonitor? Message-ID: <6043.1049662133@www26.gmx.net>
next in thread | raw e-mail | index | archive | help
This is a MIME encapsulated multipart message - please use a MIME-compliant e-mail program to open it. Dies ist eine mehrteilige Nachricht im MIME-Format - bitte verwenden Sie zum Lesen ein MIME-konformes Mailprogramm. --========GMXBoundary60431049662133 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Well, I'll see if I can manage that. But for now, i found out these thing: 1) I must set ALL right codes in /etc/isdnd.rc i'm interrested in (the man-page isn't clear about that). So to monitor and controll from remote I have to set: monitor = "192.168.1.0/24" monitor-access = fullcmd monitor-access = logevents monitor-access = callout monitor-access = callin monitor-access = channelstate 2) There is a error in /usr/src/usr.sbin/i4b/isdnmonitor/monitor.h original defined is #define I4B_MON_ICTRL_SIZE I4B_MON_EVNT_HDR+I4B_MAX_MON_STRING+8 but isdnd writes 10 Bytes after the controller string, so with #define I4B_MON_ICTRL_SIZE I4B_MON_EVNT_HDR+I4B_MAX_MON_STRING+10 everything works. BTW: the number of channels per controller seems to be hard-coded to 2 (two) channels per controller in /usr/src/usr.sbin/i4b/isdnd/monitor.c! 3) There is another error in monitor.h #define I4B_MON_DRINI_CODE 2 /* event code */ and #define I4B_MON_IDEV_CODE 2 have the same message code, changing results in correct message generating For now I can do further work on my project. I'm not familiar with coding in C. I attached my changes to monitor.h as patch. Please give me your feedback. Thank you Markus Dolze Hellmuth Michaelis wrote: > To answer your questions: > > > 3) use send-pr to file a bug. Including a good description and a > tested patch raises the chance to get the bug fixed. If you add > _any_ new features or functionality, make diffs/patches on -current > (5.x currently) since this is the platform for _new_ stuff to add > (_new_ stuff gets added _only_ to -current and if it works it will > perhaps be merged int 4.x - since 5.0 has just been released, its > just a matter of time when 4.x will disappear [from the forhead of > the developers]; already it makes not much sense to me to develop > on 4.x anymore ..). > > hellmuth --========GMXBoundary60431049662133 Content-Type: application/octet-stream; name="patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch" LS0tIG1vbml0b3IuaAlXZWQgQXVnICAxIDE5OjQ1OjA2IDIwMDEKKysrIG1vbml0b3IyLmgJU3Vu IEFwciAgNiAyMjo0NDowOSAyMDAzCkBAIC0xMTksMTIgKzExOSwxMiBAQAogI2RlZmluZQlJNEJf TU9OX0lEQVRBX0NMQUNDRVNTCQlJNEJfTU9OX0VWTlRfSERSKzgJLyogNCBieXRlOiBjbGllbnQg cmlnaHRzICovCiAKIC8qIGZvbGxvd2VkIGJ5IHRoaXMgZm9yIGV2ZXJ5IGNvbnRyb2xsZXIgKi8K LSNkZWZpbmUJSTRCX01PTl9JQ1RSTF9TSVpFCQlJNEJfTU9OX0VWTlRfSERSK0k0Ql9NQVhfTU9O X1NUUklORys4CisjZGVmaW5lCUk0Ql9NT05fSUNUUkxfU0laRQkJSTRCX01PTl9FVk5UX0hEUitJ NEJfTUFYX01PTl9TVFJJTkcrMTAKICNkZWZpbmUJSTRCX01PTl9JQ1RSTF9DT0RFCQkxCQkJCQkv KiBldmVudCBjb2RlICovCiAjZGVmaW5lCUk0Ql9NT05fSUNUUkxfTkFNRQkJSTRCX01PTl9FVk5U X0hEUiswCQkJLyogc3RyaW5nOiBuYW1lIG9mIGNvbnRyb2xsZXIgKi8KICNkZWZpbmUJSTRCX01P Tl9JQ1RSTF9CVVNJRAkJSTRCX01PTl9FVk5UX0hEUitJNEJfTUFYX01PTl9TVFJJTkcrMAkvKiAy IGJ5dGU6IGlzZG4gYnVzIGlkIChyZXNlcnZlcmVkKSAqLwogI2RlZmluZQlJNEJfTU9OX0lDVFJM X0ZMQUdTCQlJNEJfTU9OX0VWTlRfSERSK0k0Ql9NQVhfTU9OX1NUUklORysyCS8qIDQgYnl0ZTog Y29udHJvbGxlciBmbGFncyAobm90IHlldCBkZWZpbmVkKSAqLwotI2RlZmluZQlJNEJfTU9OX0lD VFJMX05DSEFOCQlJNEJfTU9OX0VWTlRfSERSK0k0Ql9NQVhfTU9OX1NUUklORys2CS8qIDIgYnl0 ZTogbnVtYmVyIG9mIGIgY2hhbm5lbHMgb24gdGhpcyBjb250cm9sbGVyICovCisjZGVmaW5lCUk0 Ql9NT05fSUNUUkxfTkNIQU4JCUk0Ql9NT05fRVZOVF9IRFIrSTRCX01BWF9NT05fU1RSSU5HKzYJ LyogNCBieXRlOiBudW1iZXIgb2YgYiBjaGFubmVscyBvbiB0aGlzIGNvbnRyb2xsZXIgKi8KIAog LyogZm9sbG93ZWQgYnkgdGhpcyBmb3IgZXZlcnkgZW50cnkgKi8KICNkZWZpbmUJSTRCX01PTl9J REVWX1NJWkUJCUk0Ql9NT05fRVZOVF9IRFIrSTRCX01BWF9NT05fU1RSSU5HKzIKQEAgLTE1MCw3 ICsxNTAsNyBAQAogICogaW4gcmVzcG9uc2UgdG8gYSBJNEJfTU9OX0RVTVBSSUdIVFNfQ09ERSBj b21tYW5kLCB0aGUgZGFlbW9uIHNlbmRzCiAgKiB0aGlzIGV2ZW50OgogICovCi0jZGVmaW5lCUk0 Ql9NT05fRFJJTklfQ09ERQkJMgkvKiBldmVudCBjb2RlICovCisjZGVmaW5lCUk0Ql9NT05fRFJJ TklfQ09ERQkJMTQJLyogZXZlbnQgY29kZSAqLwogI2RlZmluZQlJNEJfTU9OX0RSSU5JX1NJWkUJ CUk0Ql9NT05fRVZOVF9IRFIrMgkvKiBzaXplIG9mIHBhY2tldCAqLwogI2RlZmluZQlJNEJfTU9O X0RSSU5JX0NPVU5UCQlJNEJfTU9OX0VWTlRfSERSKzAJLyogMiBieXRlOiBudW1iZXIgb2YgcmVj b3JkcyAqLwogCg== --========GMXBoundary60431049662133--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6043.1049662133>