Date: Tue, 26 Feb 2002 19:16:25 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Jake Burkholder <jake@locore.ca>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 exception.s genassym.c machdep.c mp_machdep.c mpapic.c swtch.s vm_machdep.c src/sys/i386/include cpufunc.h pcb.h src/sys/i386/isa apic_vector.s clock.c icu_vector.s intr_machdep.c intr_machdep.h npx.c src/sys/kern ... Message-ID: <65129.1014747385@critter.freebsd.dk> In-Reply-To: Your message of "Tue, 26 Feb 2002 10:06:16 PST." <200202261806.g1QI6GL94130@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200202261806.g1QI6GL94130@apollo.backplane.com>, Matthew Dillon wri tes: >:> Log: >:> STAGE-1 of 3 commit - allow (but do not require) interrupts to remain >:> enabled in critical sections and streamline critical_enter() and >:> critical_exit(). >:> >: >:This patch was in dispute and still being discussed. Both jhb and bde >:had issues with it which were not resolved. It should not have been >:committed until these issues were resolved. This does not set a very >:good precedent for developer relations. Please back it out. >: >:Jake I back this suggestion. > I will not back it out. JHB has had issues with every single goddamn > thing I've tried to do that has been SMP related. JHB has had > patches going stale in P4 related to just about every file I've ever > had to touch. > > He has cried wolf one too many times. It is totally inappropriate for > JHB to put a lock on the entire SMP subsystem. > > JHB needs to get his act together. I'm not entirely convinced either of you have it right, I can see some merits in your BDE-inspired work, but I can also see some a lot of merits in JHB's 'everything will be preemptable' approach. I'll also even concede that jhb should commit more often. But you walking all over people is not acceptable, even in those circumstances. Please back this out Matt. The project is being torn apart by these bi-monthly Dillonizations, and it puts a lot of stress on a lot of people, we really don't need that. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?65129.1014747385>