Date: Tue, 21 Oct 1997 21:44:09 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Ollivier Robert <roberto@keltia.freenix.fr> Cc: current@FreeBSD.ORG Subject: Re: nullfs & current UPDATE! Message-ID: <694.877463049@critter.freebsd.dk> In-Reply-To: Your message of "Tue, 21 Oct 1997 20:38:07 %2B0200." <19971021203807.51847@keltia.freenix.fr>
next in thread | previous in thread | raw e-mail | index | archive | help
By the powers vested in us, we hereby announce that as of this
_____Tir 21 Okt 1997 21:35:09 CEST____
it has been satisfied to us that the attached email fully and
entirely prove to us that the insight and persistence needed
for successful VFS hacking is present in the necessary amount in
_____Mr Ollivier Robert <roberto@keltia.freenix.fr>_____
and therefore let it be know that he from this day on in his
good right to carry the title of
_____ VFS hacker ____
with all the rights, duties, priviledges and ensignia that goes
with this title.
Poul-Henning Kamp
<phk@freebsd.org>
PS: I trust that you commit the fix yourself ?
PPS: Yes, umapfs probably also needs this.
PPPS: would you mind looking at unionfs or lfs next ? please ? :-)
>According to Poul-Henning Kamp:
>> Whatever needs to be done should probably be done in null_inactive(),
>> look at sys/ufs/ufs/ufs_inode.c:ufs_inactive().
>
>By using the following patch, I've been able to create and delete hundreds
>of files in a nullfs mounted directory. No vnode leak as far as I can see
>from the sysctl debug.numvnodes. fsck reports no missing blocks. No panic,
>just works. Now that seems too easy :-)
>
>I know there is a comment in null_inactive() about doing nothing in there
>but it seemed logical to inform the lower layer...
>
>PS: a similar problem is in umapfs which is based on nullfs.
>
>Opinions about this ?
>
>Index: null_vnops.c
>===================================================================
>RCS file: /spare/FreeBSD-current/src/sys/miscfs/nullfs/null_vnops.c,v
>retrieving revision 1.24
>diff -u -2 -r1.24 null_vnops.c
>--- null_vnops.c 1997/10/15 10:04:31 1.24
>+++ null_vnops.c 1997/10/21 18:31:52
>@@ -534,4 +534,7 @@
> } */ *ap;
> {
>+ struct vnode *vp = ap->a_vp;
>+ struct null_node *xp = VTONULL(vp);
>+ struct vnode *lowervp = xp->null_lowervp;
> /*
> * Do nothing (and _don't_ bypass).
>@@ -546,4 +549,5 @@
> * That's too much work for now.
> */
>+ VOP_INACTIVE(lowervp, ap->a_p);
> VOP_UNLOCK(ap->a_vp, 0, ap->a_p);
> return (0);
>
>--
>Ollivier ROBERT -=- FreeBSD: There are no limits -=- roberto@keltia.freenix.fr
>FreeBSD keltia.freenix.fr 3.0-CURRENT #41: Sat Oct 18 18:47:01 CEST 1997
--
Poul-Henning Kamp FreeBSD coreteam member
phk@FreeBSD.ORG "Real hackers run -current on their laptop."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?694.877463049>