Date: Fri, 19 Nov 2010 09:08:50 -0800 From: Marcel Moolenaar <xcllnt@mac.com> To: Sergey Kandaurov <pluknet@gmail.com> Cc: Alexander Best <arundel@freebsd.org>, freebsd-current@freebsd.org Subject: Re: old references to vfs_mountroot_try() Message-ID: <6E2CBEBA-FFD7-4BBF-BFAD-192935040105@mac.com> In-Reply-To: <AANLkTi=opRz6iP8_-KR9uM904KHRnR6NkDu6o75Uet%2Bv@mail.gmail.com> References: <20101118231411.GA5121@freebsd.org> <AANLkTi=opRz6iP8_-KR9uM904KHRnR6NkDu6o75Uet%2Bv@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Nov 19, 2010, at 2:09 AM, Sergey Kandaurov wrote: > On 19 November 2010 02:14, Alexander Best <arundel@freebsd.org> wrote: >> hi there, >> >> vfs_mountroot_try() seems to have been removed, yet the src still contains >> three references to it: >> >> vfs_mount.c:386 >> vfs_mount.c:723 >> freebsd32_misc.c:2368 >> > > So, what about just to rename those comments to reflect function name change? > > Index: sys/kern/vfs_mount.c > =================================================================== > --- sys/kern/vfs_mount.c (revision 215516) > +++ sys/kern/vfs_mount.c (working copy) > @@ -383,7 +383,7 @@ > * Filter out MNT_ROOTFS. We do not want clients of nmount() in > * userspace to set this flag, but we must filter it out if we want > * MNT_UPDATE on the root file system to work. > - * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try(). > + * MNT_ROOTFS should only be set in the kernel in parse_mount(). > */ > uap->flags &= ~MNT_ROOTFS; > Keep it vague. Just change the line to "MNT_ROOTFS should only be set by the kernel when mounting its root file system". The parse_mount() function name has no meaning other than within sys/kern/vfs_mountroot.c, so referring to it isn't making things clear. FYI, -- Marcel Moolenaar xcllnt@mac.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6E2CBEBA-FFD7-4BBF-BFAD-192935040105>