Date: Mon, 29 Jun 2020 21:42:01 -0400 From: Allan Jude <allanjude@freebsd.org> To: freebsd-fs <freebsd-fs@freebsd.org> Subject: Re: ZSTD Project Weekly Status Update Message-ID: <708ec9f2-3c5c-6452-f6e6-bfb11a7f7eb2@freebsd.org> In-Reply-To: <7b8842ad-d520-c575-22ee-2cd77244f2c6@freebsd.org> References: <7b8842ad-d520-c575-22ee-2cd77244f2c6@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --612zfeGV38IdUQknGJ724Lxcls0v44tr2 Content-Type: multipart/mixed; boundary="AUlwrInjLHPj4CRv5GJltZ10ewp1oFUWZ"; protected-headers="v1" From: Allan Jude <allanjude@freebsd.org> To: freebsd-fs <freebsd-fs@freebsd.org> Message-ID: <708ec9f2-3c5c-6452-f6e6-bfb11a7f7eb2@freebsd.org> Subject: Re: ZSTD Project Weekly Status Update References: <7b8842ad-d520-c575-22ee-2cd77244f2c6@freebsd.org> In-Reply-To: <7b8842ad-d520-c575-22ee-2cd77244f2c6@freebsd.org> --AUlwrInjLHPj4CRv5GJltZ10ewp1oFUWZ Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable In my continued effort to finish the integration of ZSTD into ZFS, here is my second weekly status report: There is still a number of existing feedback items and known issues that need to be addressed. I am trying to work through those now. https://github.com/openzfs/zfs/commit/622b7e1e50ab667a6af1685245a2f5a8d5e= 9bff3 - Addressed an issue where the user could manually set the hidden compress_level property, causing incorrect operation. The property is not marked with the PROP_READONLY flag because it requires PROP_INHERIT - It has been pointed out again recently that setting the compress=3Dzstd= property on a dataset, but not actually writing any blocks, does not set the zstd feature flag to 'active'. If this pool is then exported, and imported using an older version of ZFS that does not know of zstd, it will trigger an ASSERT() when the value of the compression property enum is out-of-range. The plan is to fully activate the feature when the property is set, but the details of how (and where) to do still still need to be worked out. - I am still working on the issue of inheritance for both the compress and the hidden compress_level properties. If you create a child dataset with the compress property set to zstd-13, it works as expected. But if you `zfs inherit compress` on that dataset, the output of `zfs get compress,compress_level` changes from: zof/inherit/zstd-10/zstd-13 compression zstd-13 local zof/inherit/zstd-10/zstd-13 compress_level 13 local to: zof/inherit/zstd-10/zstd-13 compression zstd-13 inherited from zof/inherit/zstd-10 zof/inherit/zstd-10/zstd-13 compress_level 13 local This is due to the fact that both the parent, and the child, actually have compress=3D16 (zstd), and the zstd-10 or zstd-13 is determined by combining the hidden compress_level property. The expected behaviour in this case would be that the compression type (and therefore the compress_level) would get reset to the value from the parent. There is a related problem when the child's compression setting is set to lz4 (or any other type that doesn't use a level). This project was sponsored by the FreeBSD Foundation. --=20 Allan Jude --AUlwrInjLHPj4CRv5GJltZ10ewp1oFUWZ-- --612zfeGV38IdUQknGJ724Lxcls0v44tr2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJe+phpAAoJEBmVNT4SmAt+U98P/0RI9o/VfCUVPNs0vIjpmwxw edpO5chNAcbyISVXws6/e7rM6EVwxZeNfNRpJbIEkuIP/JcPxAwCu+FXWcrSZlLt psShyzIGJD4S2ZI53ZUnksa3KEO266pu3H79hiELBzhlvPbVfJBp8kQ/O0adxXnF MI637R/ykEgUqKEjBaZaod83Si3+JOy+PRCHNTccHeRY+x2NHAAyGYdYl7LocyaA MzJvQDiPdJS/EB/xusiToNFDkeOFw5kPgVc8siuHi6uAmFsHp3fbETTBOZP37A0d PmFPyXFtTeoZbX+q/ipsKNpX0xLKd6kuor8wAfJoFuWM1czlV733JqIkaNxoqI1w MgKEPoXXaQhR9cANaLgOiaCMLS7XdCGUMQ+8spyhpEVgKY/zK5DM1Hz6cluuAuAs UOWK2oB5erk6tEKtCdue0n1Qax97mZ8GNL3yKpOHBXY+MwVKbVj5q9z4NBdSxASl 1uakIsqy4ZV8Ric4vdHVZyxRfJH+0rzmqphARHAopDdmK3pFpdVDDHqBWPHGq4U6 VMkwUqZX3COTsrm/+Ux9Ygb4CZalfq4btP1YVvfrexH9eGyG1DfPCAfLGCeu0xWK 6FUb5Oh2vh4F9gcI6vAjoLC6T1/V9zKmYPBsjAF6por//bsOT/YHVAMccjzjcX+m wdbZ+Hj6kt9XHK3xi/SJ =vtmX -----END PGP SIGNATURE----- --612zfeGV38IdUQknGJ724Lxcls0v44tr2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?708ec9f2-3c5c-6452-f6e6-bfb11a7f7eb2>