Date: Thu, 3 Aug 2006 15:35:04 +0100 From: "Joao Barros" <joao.barros@gmail.com> To: freebsd-hackers@freebsd.org Cc: Gleb Smirnoff <glebius@freebsd.org> Subject: [PATCH] add header "pppoe:" in ng_pppoe.c printfs Message-ID: <70e8236f0608030735m519d880fgebeca7108b859244@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Hi,
I recently switched ISPs which in turn led me from a cablemodem to an
ADSL modem.
After setting PPPoE up I started noticing this messages in the daily
run outputs that that nice guy Charlie root sends me at 3am:
Aug 3 08:24:54 ultra5 kernel: session in wrong state
I was a bit suspicious of anything PPPoE related and a little search
confirmed that, pointing directly at ng_pppoe.c
Being this a cryptic message to say the least and to probably save
someone some time when presented with this message I attach a patch
that adds the header "pppoe:" in every printf that didn't have it,
making it consistent with the rest of the file.
I also noticed this message appears right before the ISP closes the
connection due to time limit.
I'm CCing those I see were the last ones to commit to this file and
will file a PR if asked to.
--
Joao Barros
[-- Attachment #2 --]
--- ng_pppoe.c.original Thu Aug 03 15:09:51 2006
+++ ng_pppoe.c Thu Aug 03 15:16:15 2006
@@ -1108 +1108 @@
- printf("couldn't m_pullup\n");
+ printf("pppoe: couldn't m_pullup\n");
@@ -1127 +1127 @@
- printf("couldn't m_pullup\n");
+ printf("pppoe: couldn't m_pullup\n");
@@ -1150 +1150 @@
- printf("packet fragmented\n");
+ printf("pppoe: packet fragmented\n");
@@ -1207 +1207 @@
- printf("no host unique field\n");
+ printf("pppoe: no host unique field\n");
@@ -1213 +1213 @@
- printf("no matching session\n");
+ printf("pppoe: no matching session\n");
@@ -1223 +1223 @@
- printf("session in wrong state\n");
+ printf("pppoe: session in wrong state\n");
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?70e8236f0608030735m519d880fgebeca7108b859244>