Date: Sat, 5 Aug 2006 00:42:12 +0100 From: "Joao Barros" <joao.barros@gmail.com> To: "Gleb Smirnoff" <glebius@freebsd.org> Cc: freebsd-hackers@freebsd.org Subject: Re: [PATCH] add header "pppoe:" in ng_pppoe.c printfs Message-ID: <70e8236f0608041642v5c7a85a9u4e4422bb6f08822f@mail.gmail.com> In-Reply-To: <20060804182123.GH96644@cell.sick.ru> References: <70e8236f0608030735m519d880fgebeca7108b859244@mail.gmail.com> <20060804150302.GD96644@cell.sick.ru> <70e8236f0608040848x304a671cle6d490f43735737b@mail.gmail.com> <20060804182123.GH96644@cell.sick.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/4/06, Gleb Smirnoff <glebius@freebsd.org> wrote: > On Fri, Aug 04, 2006 at 04:48:49PM +0100, Joao Barros wrote: > J> On 8/4/06, Gleb Smirnoff <glebius@freebsd.org> wrote: > J> >On Thu, Aug 03, 2006 at 03:35:04PM +0100, Joao Barros wrote: > J> >J> Being this a cryptic message to say the least and to probably save > J> >J> someone some time when presented with this message I attach a patch > J> >J> that adds the header "pppoe:" in every printf that didn't have it, > J> >J> making it consistent with the rest of the file. > J> > > J> >I've attached a patch that cleans a bit logging in ng_pppoe. It changes > J> >all printf(9) to log(9). The latter is better since it spams console > J> >less, if event occurs many times per second. Also I've made the messages > J> >more clear - prepended node ID where possible, function name when it > J> >starts with ng_pppoe, or just "ng_pppoe". > J> > > J> >Can you please try out this patch and tell whether you like it. If you > J> >do I will commit it soon. > J> > J> Hi, > J> > J> I've looked at the patch and it looks ok. > J> It serves the purpose: make the messages more clear with the added > J> bonus of more info. > J> Thanks for taking the time to look into this :-) > > Since I don't use ng_pppoe now much, I'd appreciate if you > do at brief test of this patch, before I commit it. > I patched and recompiled the kernel. After booting I notice that no messages from ppp are logged by syslog (messages|ppp.log) If I restart ppp the messages are all logged. I can't say if this was happening because after setting ppp up I didn't reboot the machine. I didn't browse the startup scripts but maybe syslog is not started before pppoe. Now it will take more than 17 hours for the session limit to be exceeded and only then I can say how your patch worked out. I'll make an update then. -- Joao Barros
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?70e8236f0608041642v5c7a85a9u4e4422bb6f08822f>