Date: Sun, 28 Nov 2010 23:53:13 +0100 From: =?iso-8859-2?Q?Edward_Tomasz_Napiera=B3a?= <trasz@FreeBSD.org> To: James R. Van Artsdalen <james-freebsd-fs2@jrv.org> Cc: freebsd-fs <freebsd-fs@freebsd.org> Subject: Re: ZFS panic: empty ZFS ACL Message-ID: <7A3D90B8-EEC0-4FC2-9744-C58379709901@FreeBSD.org> In-Reply-To: <4CF26B15.6090009@jrv.org> References: <4CF26B15.6090009@jrv.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Wiadomo=B6=E6 napisana przez James R. Van Artsdalen w dniu 2010-11-28, o =
godz. 15:45:
> amd64
> Version String: FreeBSD 9.0-CURRENT #0 r214378M: Sun Nov 28 07:52:25
> CST 2010 root@kraken.housenet.jrv:/usr/obj/usr/src/sys/GENERIC
> Panic String: empty ZFS ACL
>=20
> I got this panic via "ls -l" after copying in a very old pool via zfs
> send/recv: the pool originated on Macintosh ZFS just after Apple first
> released the initial build of that.
Could you try the patch below?
Index: sys/cddl/compat/opensolaris/kern/opensolaris_acl.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/cddl/compat/opensolaris/kern/opensolaris_acl.c (revision =
215553)
+++ sys/cddl/compat/opensolaris/kern/opensolaris_acl.c (working copy)
@@ -105,7 +105,10 @@
struct acl_entry *entry;
const ace_t *ace;
=20
- KASSERT(nentries >=3D 1, ("empty ZFS ACL"));
+ if (nentries < 1) {
+ printf("acl_from_aces: empty ZFS ACL; returning =
EINVAL.\n");
+ return (EINVAL);
+ }
=20
if (nentries > ACL_MAX_ENTRIES) {
/*
--
If you cut off my head, what would I say? Me and my head, or me and my =
body?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7A3D90B8-EEC0-4FC2-9744-C58379709901>