Date: Sat, 6 Dec 2014 16:01:26 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: FreeBSD CURRENT <freebsd-current@freebsd.org> Subject: Re: Build failed in Jenkins: Build-UFS-image #599 Message-ID: <7A7677F9-AD1B-436C-9A49-054F7CD6BBC4@FreeBSD.org> In-Reply-To: <D290A7DA-0AED-4810-A1B1-470E35542292@gmail.com> References: <1052304530.8.1417827164793.JavaMail.jenkins@jenkins-9.freebsd.org> <D290A7DA-0AED-4810-A1B1-470E35542292@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_D42ECA94-2B71-4A56-BFC7-437C7545F92E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 [trimmed CC list to -current] On 06 Dec 2014, at 04:59, Garrett Cooper <yaneurabeya@gmail.com> wrote: > On Dec 5, 2014, at 16:52, jenkins-admin@freebsd.org wrote: >=20 >> See <https://jenkins.freebsd.org/job/Build-UFS-image/599/>; >=20 > I=92m not entirely sure why the "could not determine = COMPILER_TYPE" error popped up, but I have a couple of = questions/concerns related to the makefile snippet. > 1. Does it make sense to check CC when running make install? Yes, of course it makes sense, if parts of the install depend on e.g. COMPILER_TYPE. In some cases, you will have to run ${CC} to determine what it is, specifically if it is just "cc". > 2. Why isn=92t this value determined once in Makefile.inc1 (per = build phase), then passed down from there Because you are supposed to be able to build stuff in a subdirectory, without invoking the full top-level Makefile infrastructure. The actual infrastructure is in share/mk/bsd.*.mk, in fact. > (I=92ve already considered the scenario where someone explicitly sets = CC in a non-toplevel Makefile, which is a problem, but an outlier rather = than the norm)? AFAICT, it gets recomputed for every recursive make, = which contributes to useless forking for something that honestly doesn=92t= change all that often/at all. This is indeed a pity, and if you know a better solution, let's hear it, please. :-) > At EMC/Isilon at least, we set CC/CXX=3Dfalse when running make = distribute*/installkernel/installworld to catch logic errors with = rebuilding code. Should this be in FreeBSD? Not sure what that is meant to achieve. If parts of the installation depend on the value of CC, why would you want to set it to false? Just so it can error out at those points? -Dimitry --Apple-Mail=_D42ECA94-2B71-4A56-BFC7-437C7545F92E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.26 iEYEARECAAYFAlSDGk0ACgkQsF6jCi4glqPpCQCg7VQWfZ+hviA/pQATDH+vm4Kg 7msAoKzjjkk4FNuOLWsq0ApAz61ezoyh =dsDt -----END PGP SIGNATURE----- --Apple-Mail=_D42ECA94-2B71-4A56-BFC7-437C7545F92E--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7A7677F9-AD1B-436C-9A49-054F7CD6BBC4>