Date: Fri, 9 Jun 2017 20:19:38 +1000 From: Kubilay Kocak <koobs@FreeBSD.org> To: Marco Beishuizen <mbeis@xs4all.nl>, freebsd-ports@freebsd.org Subject: Re: mail/alpine new Makefile Message-ID: <7b39bcd3-ee60-4ef9-ff4b-fdb35b3fad73@FreeBSD.org> In-Reply-To: <alpine.BSF.2.21.1706091129350.2993@yokozuna> References: <alpine.BSF.2.21.1706091129350.2993@yokozuna>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/9/17 7:41 PM, Marco Beishuizen wrote:
Hi Marco,
I believe the reason is:
> OPTIONS_DEFINE= ASPELL CONS25 DOCS IPV6 LDAP MAILDIR MOUSE NLS
> NOSPELL PASSFILE PICO THREADS
> OPTIONS_DEFAULT+= MOUSE PICO THREADS
>
> CONS25_DESC= Add a patch to support color for default console
> MAILDIR_DESC= Add a patch for maildir support
> NOSPELL_DESC= Use simple spellcheck
> PASSFILE_DESC= Support for a stored password file
> PICO_DESC= Build and install pico, the default editor
>
> .include <bsd.port.options.mk>
The port includes this ^^^^ ... AND
> # Option ASPELL
> ASPELL_CONFIGURE_WITH= interactive-spellcheck
> ASPELL_CONFIGURE_ON=
> --with-interactive-spellcheck=${LOCALBASE}/bin/aspell
> ASPELL_BUILD_DEPENDS= aspell:textproc/aspell
> ASPELL_RUN_DEPENDS= aspell:textproc/aspell
>
<snip>
> # Option PICO
> PICO_RUN_DEPENDS= pico:editors/pico-alpine
>
> # Option THREADS
> THREADS_CONFIGURE_WITH= pthread
>
> .include <bsd.port.pre.mk>
This ---------^^^^^
Use one or the other, or neither if its *all* options helpers, but not
both. See:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html
The paragraph just above the "Example 5.28. Simple Use of OPTIONS"
> post-install-DOCS-on:
> ${INSTALL} -d ${STAGEDIR}${DOCSDIR} ${STAGEDIR}${DOCSDIR}/tech-notes
> .for f in ${PORTDOCSbase}
> ${INSTALL_MAN} ${WRKSRC}/$f ${STAGEDIR}${DOCSDIR}
> .endfor
> .for f in ${PORTDOCSdoc}
> ${INSTALL_MAN} ${WRKSRC}/doc/$f ${STAGEDIR}${DOCSDIR}
> .endfor
> .for f in ${PORTDOCShtml}
> ${INSTALL_MAN} ${WRKSRC}/doc/$f ${STAGEDIR}${DOCSDIR}/tech-notes
> .endfor
>
> .include <bsd.port.post.mk>
>
>
> The port builds and installs just fine, except that the port options
> don't work. The checked options, other than the default, are being
> ignored. For testing I've marked all options to on, but Alpine for
> example still doesn't have the possibility to save passwords built in.
>
> So what is wrong with this Makefile?
>
> Regards,
> Marco
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7b39bcd3-ee60-4ef9-ff4b-fdb35b3fad73>