Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Mar 2010 21:55:35 -0800
From:      Garrett Cooper <yanefbsd@gmail.com>
To:        Alexander Best <alexbestms@wwu.de>
Cc:        freebsd-hackers@freebsd.org, Doug Barton <dougb@freebsd.org>
Subject:   Re: [patch] small fix to stop gcc warning for lib/libstand/assert.c
Message-ID:  <7d6fde3d1003132155t3059a438m80bd50fdf1dbe091@mail.gmail.com>
In-Reply-To: <4B9C72FE.2060907@FreeBSD.org>
References:  <permail-20100313135219f7e55a9d00006340-a_best01@message-id.uni-muenster.de> <4B9C72FE.2060907@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 13, 2010 at 9:24 PM, Doug Barton <dougb@freebsd.org> wrote:
> On 03/13/10 05:52, Alexander Best wrote:
>> hello,
>>
>> this patch fixes the following gcc warning:
>
> For all such issues, please file a PR first so it doesn't get lost. When
> you get the PR confirmation back, feel free to alert the list to its
> existence.

   Yes, please submit a proper PR for this because it's a code bug;
FYI, your solution isn't complete though (it's close):

ABORT(3)               FreeBSD Library Functions Manual               ABORT(3)

NAME
     abort -- cause abnormal program termination

LIBRARY
     Standard C Library (libc, -lc)

SYNOPSIS
     #include <stdlib.h>

     void
     abort(void);

    Please be explicit and add stdlib.h.
Thanks,
-Garrett



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7d6fde3d1003132155t3059a438m80bd50fdf1dbe091>