Date: Sun, 03 Sep 2000 23:44:42 +0900 From: "Akinori -Aki- MUSHA" <knu@idaemons.org> To: kiri@pis.toba-cmt.ac.jp Cc: freebsd-ports@FreeBSD.org, asami@FreeBSD.org, shige@FreeBSD.org Subject: Re: bsd.ruby.mk, bsd.gnome.mk, ... etc. Message-ID: <867l8tilgl.wl@archon.local.idaemons.org> In-Reply-To: In your message of "Sun, 03 Sep 2000 20:44:58 %2B0900" <200009031145.e83BiwG85980@pis.toba-cmt.ac.jp> References: <86g0nl8yr3.wl@archon.local.idaemons.org> <86d7ilj1eg.wl@archon.local.idaemons.org> <vqchf7xx2ci.fsf@silvia.hip.berkeley.edu> <200009031145.e83BiwG85980@pis.toba-cmt.ac.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
At Sun, 03 Sep 2000 20:44:58 +0900, kiri@pis.toba-cmt.ac.jp wrote: > +INCLUDEMK_CATEGORIES= elisp ruby gnome kde > +__incmkfiles!= \ > + for cat in ${INCLUDEMK_CATEGORIES}; do \ > + if echo ${CATEGORIES} | grep -wq $$cat; then \ > + echo "bsd.$$cat.mk"; \ > + fi; \ > + done > +.for file in ${__incmkfiles} > +.include "${PORTSDIR}/Mk/${file}" > +.endfor > check-categories: > .for cat in ${CATEGORIES} > @if ${ECHO} ${VALID_CATEGORIES} | ${GREP} -wq ${cat}; then \ The idea seems fine, however, it'd better check if each file exists instead of predefining INCLUDEMK_CATEGORIES: __incmkfiles!= \ for cat in ${CATEGORIES}; do \ mk="${PORTSDIR}/Mk/bsd.$$cat.mk"; \ [ -f $$mk ] && echo $$mk; \ done; exit 0 .if !empty(__incmkfiles) .for file in ${__incmkfiles} .include "${file}" .endfor .endif Incidentally, bsd.emacs.mk should probably be renamed bsd.elisp.mk to accomplish this. (I'm CC'ing this mail to the MAINTAINER of it) And now I think bsd.cat.*.mk or such might look better... Just imagine this in the future: $ ls -1 /usr/ports/Mk bsd.elisp.mk bsd.gnome.mk bsd.kde.mk bsd.perl5.mk bsd.port.mk bsd.port.post.mk bsd.port.pre.mk bsd.port.subdir.mk bsd.python.mk bsd.ruby.mk bsd.sites.mk bsd.windowmaker.mk Comments on any of the above, everyone? -- / /__ __ / ) ) ) ) / Akinori -Aki- MUSHA aka / (_ / ( (__( @ idaemons.org / FreeBSD.org "We're only at home when we're on the run, on the wing, on the fly" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?867l8tilgl.wl>