Date: Tue, 09 Oct 2018 21:18:09 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Michael Butler <imb@protected-networks.net> Cc: Marek Zarychta <zarychtam@plan-b.pwste.edu.pl>, emaste@freebsd.org, FreeBSD Current <freebsd-current@FreeBSD.org> Subject: Re: SVN r339216 breaks ssh to i386 devices Message-ID: <86bm839bf2.fsf@next.des.no> In-Reply-To: <375ebc04-82a3-6497-ad60-5afee1088f0a@protected-networks.net> (Michael Butler's message of "Tue, 9 Oct 2018 13:46:10 -0400") References: <6bd10ee9-eb03-1f9f-c533-fdb5d02eb829@protected-networks.net> <20181008190846.GA84941@plan-b.pwste.edu.pl> <86tvlwcee0.fsf@next.des.no> <86lg78c92o.fsf@next.des.no> <1e8f80dd-d7c9-e82c-987f-f84c4103a039@plan-b.pwste.edu.pl> <375ebc04-82a3-6497-ad60-5afee1088f0a@protected-networks.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Michael Butler <imb@protected-networks.net> writes: > Marek Zarychta <zarychtam@plan-b.pwste.edu.pl> writes: > > I have connected serial console to affected box and upgraded system > > from patched sources. I am sorry to say that this patch doesn't > > solve the issue for 32-bit ARM (RPi2). Still sshd terminates session > > with the error "fatal: mm_getpwnamallow: receive get struct passwd > > failed [preauth]". > My experience is similar - there maybe another 32/64-bit issue :-( Correct, there is a size_t being passed as as an u64 as well. That explains why arm32 was broken too, and not just i386. The quick fix is to replace size_t with u_int64_t in sshbuf_get_passwd(), on line 513 of sshbuf-getput-basic.c (with my previous patch applied). I have a full patch in the pipeline. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86bm839bf2.fsf>