Date: Tue, 11 Jul 2006 10:26:31 +0200 From: des@des.no (Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?=) To: mag@intron.ac Cc: freebsd-hackers@freebsd.org, delphij@delphij.net, Julian Elischer <julian@elischer.org> Subject: Re: kern/99979: Get Ready for Kernel Module in C++ Message-ID: <86fyh8zgw8.fsf@xps.des.no> In-Reply-To: <courier.44B35DBC.00003F75@intron.ac> (mag@intron.ac's message of "Tue, 11 Jul 2006 16:13:48 %2B0800") References: <200607092136.k69LaNDX055391@www.freebsd.org> <84dead720607092015q7f1701abse143f3855c2aa95a@mail.gmail.com> <1152540567.99616@origin.intron.ac> <44B2AE69.4080703@elischer.org> <44B2D2DF.2000401@sh.cvut.cz> <86sll8zl9x.fsf@xps.des.no> <courier.44B35DBC.00003F75@intron.ac>
next in thread | previous in thread | raw e-mail | index | archive | help
mag@intron.ac writes:
> But prior to long-term discussion, please commit my 4 patches
> firstly. They are nearly CPP-independent and do no harm to current
> FreeBSD kernel.
We don't do the kind of changes you propose without discussion.
> --- kern.mk.orig Fri Jun 30 05:15:25 2006
> +++ kern.mk Mon Jul 10 18:42:43 2006
> @@ -88,7 +88,7 @@
> .if ${CC} =3D=3D "icc"
> CFLAGS+=3D -nolib_inline
> .else
> -CFLAGS+=3D -ffreestanding
> +CFLAGS+=3D -fno-builtin
> .endif
Are you sure this is correct? I'm pretty certain it isn't. The
kernel's C environment is not a hosted implementation.
> --- systm.h.orig Mon Jul 10 05:42:58 2006
> +++ systm.h Mon Jul 10 18:44:01 2006
> @@ -203,7 +203,7 @@
> int suword16(void *base, int word);
> int suword32(void *base, int32_t word);
> int suword64(void *base, int64_t word);
> -intptr_t casuptr(intptr_t *p, intptr_t old, intptr_t new);
> +intptr_t casuptr(intptr_t *p, intptr_t old, intptr_t __new__);
This is a namespace violation. A simpler solution is to leave out
argument names entirely.
DES
--=20
Dag-Erling Sm=F8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86fyh8zgw8.fsf>