Date: Sun, 13 Jun 2010 13:56:31 +0300 From: Mikolaj Golub <to.my.trociny@gmail.com> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: freebsd-fs@freebsd.org Subject: Re: FreeBSD 8.1 and HAST Message-ID: <86ljajw68w.fsf@kopusha.home.net> In-Reply-To: <4C149A5C.3070401@soupacific.com> (hiroshi@soupacific.com's message of "Sun, 13 Jun 2010 17:44:12 %2B0900") References: <20100423061521.GC1670@garage.freebsd.pl> <4BD17B0D.5080601@soupacific.com> <4C10B526.4040908@soupacific.com> <20100612104336.GA2253@garage.freebsd.pl> <4C1372E0.1000903@soupacific.com> <20100612142311.GF2253@garage.freebsd.pl> <4C139F9C.2090305@soupacific.com> <86iq5oc82y.fsf@kopusha.home.net> <4C14215D.9090304@soupacific.com> <20100613003635.GA60012@icarus.home.lan> <20100613074921.GB1320@garage.freebsd.pl> <4C149A5C.3070401@soupacific.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Just a note, not related to this problem:
On Sun, 13 Jun 2010 17:44:12 +0900 hiroshi@soupacific.com wrote:
h> Jun 13 17:35:54 sv01B hastd: Accepting connection to tcp4://0.0.0.0:8457.
h> Jun 13 17:35:54 sv01B hastd: Connection from tcp4://192.168.0.241:8457 to tcp4://192.168.0.240:24260.
It looks like the addresses in this message are swapped. Also I have noticed
one typo in another log message and the issue with send thread logging as if
it is disk thread (I reported about this earlier in this thread). Please look
at the attached patch.
--
Mikolaj Golub
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline; filename=hastd.log.patch
Index: sbin/hastd/hastd.c
===================================================================
--- sbin/hastd/hastd.c (revision 208960)
+++ sbin/hastd/hastd.c (working copy)
@@ -200,7 +200,7 @@ listen_accept(void)
proto_local_address(conn, laddr, sizeof(laddr));
proto_remote_address(conn, raddr, sizeof(raddr));
- pjdlog_info("Connection from %s to %s.", laddr, raddr);
+ pjdlog_info("Connection from %s to %s.", raddr, laddr);
/* Error in setting timeout is not critical, but why should it fail? */
if (proto_timeout(conn, HAST_TIMEOUT) < 0)
@@ -286,7 +286,7 @@ listen_accept(void)
if (token != NULL && memcmp(token, res->hr_token,
sizeof(res->hr_token)) != 0) {
pjdlog_error("Token received from %s doesn't match.", raddr);
- nv_add_stringf(nverr, "errmsg", "Toke doesn't match.");
+ nv_add_stringf(nverr, "errmsg", "Token doesn't match.");
goto fail;
}
/*
Index: sbin/hastd/secondary.c
===================================================================
--- sbin/hastd/secondary.c (revision 208960)
+++ sbin/hastd/secondary.c (working copy)
@@ -687,7 +687,7 @@ send_thread(void *arg)
pjdlog_exit(EX_TEMPFAIL, "Unable to send reply.");
}
nv_free(nvout);
- pjdlog_debug(2, "disk: (%p) Moving request to the free queue.",
+ pjdlog_debug(2, "send: (%p) Moving request to the free queue.",
hio);
nv_free(hio->hio_nv);
hio->hio_error = 0;
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86ljajw68w.fsf>