Date: Sun, 17 Oct 2010 18:34:24 +0300 From: Mikolaj Golub <to.my.trociny@gmail.com> To: freebsd-fs@freebsd.org Cc: Pawel Jakub Dawidek <pjd@freebsd.org> Subject: hastd: wrong address is logged when cancelling half-open connection Message-ID: <86zkuc4yv3.fsf@kopusha.home.net>
next in thread | raw e-mail | index | archive | help
--=-=-=
Hi,
It looks like there is a typo in the listen_accept(): when half-open
connection is cancelled hastd reports a wrong address being cancelled. See the
attached patch.
--
Mikolaj Golub
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline; filename=hastd.cancel.patch
Index: sbin/hastd/hastd.c
===================================================================
--- sbin/hastd/hastd.c (revision 213978)
+++ sbin/hastd/hastd.c (working copy)
@@ -527,7 +527,7 @@ listen_accept(void)
} else if (res->hr_remotein != NULL) {
char oaddr[256];
- proto_remote_address(conn, oaddr, sizeof(oaddr));
+ proto_remote_address(res->hr_remotein, oaddr, sizeof(oaddr));
pjdlog_debug(1,
"Canceling half-open connection from %s on connection from %s.",
oaddr, raddr);
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86zkuc4yv3.fsf>