Date: Sat, 10 Jan 2009 06:00:51 +0530 From: wahjava@gmail.com (Ashish SHUKLA) To: Dima Panov <fluffy@ael.ru> Cc: freebsd-ports-bugs@freebsd.org Subject: Re: ports/130265: Update deskutils/google-gadgets to latest version Message-ID: <874p08m284.fsf@chateau.d.lf> In-Reply-To: <200901100916.48231.fluffy@ael.ru> (Dima Panov's message of "Sat, 10 Jan 2009 09:16:46 %2B1000") References: <200901071636.n07GaOU5022390@freefall.freebsd.org> <200901100916.48231.fluffy@ael.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Transfer-Encoding: quoted-printable
Dima Panov writes:
[...]
There is a problem with your patch, I tried and installed the port in
/var/tmp/google-gadgets, and find a file 'ggl-designer.desktop' missing,
which you can see below:
,----
| abbe [google-gadgets-dima] monte-cristo% find /var/tmp/google-gadgets -ty=
pe f
| /var/tmp/google-gadgets/share/mime/subclasses
| /var/tmp/google-gadgets/share/mime/globs
| /var/tmp/google-gadgets/share/mime/globs2
| /var/tmp/google-gadgets/share/mime/magic
| /var/tmp/google-gadgets/share/mime/XMLnamespaces
| /var/tmp/google-gadgets/share/mime/aliases
| /var/tmp/google-gadgets/share/mime/types
| /var/tmp/google-gadgets/share/mime/generic-icons
| /var/tmp/google-gadgets/share/mime/icons
| /var/tmp/google-gadgets/share/mime/treemagic
| /var/tmp/google-gadgets/share/mime/mime.cache
| /var/tmp/google-gadgets/share/applications/ggl-designer.desktop
| /var/tmp/google-gadgets/share/applications/mimeinfo.cache
`----
I also diffed your and my version of ports and found following
differences:
,----
| abbe [tmp] monte-cristo% diff -urN google-gadgets-{abbe,dima}
| diff -urN google-gadgets-abbe/files/patch-ggadget_gtk_utilities.cc google=
-gadgets-dima/files/patch-ggadget_gtk_utilities.cc
| --- google-gadgets-abbe/files/patch-ggadget_gtk_utilities.cc 2009-01-1=
0 05:23:41.000000000 +0530
| +++ google-gadgets-dima/files/patch-ggadget_gtk_utilities.cc 2009-01-1=
0 05:22:41.000000000 +0530
| @@ -1,14 +1,11 @@
| -
| -$FreeBSD$
| -
| ---- ggadget/gtk/utilities.cc.orig
| -+++ ggadget/gtk/utilities.cc
| +--- ggadget/gtk/utilities.cc.orig 2008-12-03 18:01:36.000000000 +10=
00
| ++++ ggadget/gtk/utilities.cc 2009-01-07 00:52:52.000000000 +1000
| @@ -83,7 +83,7 @@
| "%s", message);
| gtk_dialog_add_buttons(GTK_DIALOG(dialog), GTK_STOCK_NO, GTK_RESPON=
SE_NO,
| GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
| - GTK_STOCK_YES, GTK_RESPONSE_YES, NULL);
| -+ GTK_STOCK_YES, GTK_RESPONSE_YES, (const gcha=
r*)0);
| ++ GTK_STOCK_YES, GTK_RESPONSE_YES, (char *)0);
| gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_YE=
S);
| } else {
| dialog =3D gtk_message_dialog_new(NULL, GTK_DIALOG_MODAL,
| diff -urN google-gadgets-abbe/pkg-plist google-gadgets-dima/pkg-plist
| --- google-gadgets-abbe/pkg-plist 2009-01-10 05:23:41.000000000 +05=
30
| +++ google-gadgets-dima/pkg-plist 2009-01-10 05:22:41.000000000 +05=
30
| @@ -230,7 +230,6 @@
| libdata/pkgconfig/libggadget-npapi-1.0.pc
| %%QT%%libdata/pkgconfig/libggadget-qt-1.0.pc
| libdata/pkgconfig/libggadget-xdg-1.0.pc
| -share/applications/ggl-designer.desktop
| %%GTK%%share/applications/ggl-gtk.desktop
| %%QT%%share/applications/ggl-qt.desktop
| %%DATADIR%%/analog-clock.gg
`----
So I'm wondering if you've forgotten to record the file or it is not
getting generated there.
And one more thing, please exclude the CVS files when taking diff.
Thanks
=2D-=20
Ashish SHUKLA
--=-=-=
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
iEYEARECAAYFAkln7D8ACgkQHy+EEHYuXnTIAQCg3e11WIGy07nK7wyXarJXa2ZB
WIcAoMBXJwKWWolBzgxisj81eV4cNGBP
=771Z
-----END PGP SIGNATURE-----
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?874p08m284.fsf>