Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 17 Sep 2024 10:27:38 +0200
From:      "Herbert J. Skuhra" <herbert@gojira.at>
To:        Kristof Provost <kp@FreeBSD.org>
Cc:        current@freebsd.org
Subject:   Re: git: 80eb861dc2a7 - main - pfctl: lex <=, >=, and != into  a single token
Message-ID:  <87wmja3csl.wl-herbert@gojira.at>
In-Reply-To: <202409161305.48GD5SMG020938@gitrepo.freebsd.org>
References:  <202409161305.48GD5SMG020938@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 16 Sep 2024 15:05:28 +0200,
Kristof Provost <kp@FreeBSD.org> wrote:
> 
> The branch main has been updated by kp:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=80eb861dc2a7960e1acc74796cf0c937472a5dba
> 
> commit 80eb861dc2a7960e1acc74796cf0c937472a5dba
> Author:     Kristof Provost <kp@FreeBSD.org>
> AuthorDate: 2024-08-29 10:08:32 +0000
> Commit:     Kristof Provost <kp@FreeBSD.org>
> CommitDate: 2024-09-16 11:48:58 +0000
> 
>     pfctl: lex <=, >=, and != into a single token
>     
>     lex <=, >=, and != into a single token for correctness and to reduce the
>     lookahead in the parser
>     ok henning otto
>     
>     Reviewed by:    zlei
>     Obtained from:  OpenBSD, deraadt <deraadt@openbsd.org>, e6e3ecf338
>     Sponsored by:   Rubicon Communications, LLC ("Netgate")
>     Differential Revision:  https://reviews.freebsd.org/D46582
> ---
>  sbin/pfctl/parse.y | 20 ++++++++++++++------
>  1 file changed, 14 insertions(+), 6 deletions(-)

Does this commit break pf on arm64?

# pfctl -f /etc/pf.conf
pfctl: failed to add host: Invalid argument

Simple pf.conf loads but

# pfctl -s rules
pass in all flags S/SA keep state
pass out all flags S/SA keep state
Abort trap (core dumped)

-- 
Herbert



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87wmja3csl.wl-herbert>