Date: Mon, 21 Mar 2016 15:35:52 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Don Lewis <truckman@FreeBSD.org>, ports@FreeBSD.org Subject: Re: gnome-post-install ordering Message-ID: <8EB21981928900BCB811B4B1@ogg.in.absolight.net> In-Reply-To: <201603161757.u2GHvsbJ038871@gw.catspoiler.org> References: <201603161757.u2GHvsbJ038871@gw.catspoiler.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========B3C56815D48710D83669==========
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
+--On 16 mars 2016 10:57:54 -0700 Don Lewis <truckman@FreeBSD.org> wrote:
| I'm trying to debug why gtk-update-icon-cache isn't getting run when
| the OpenOffice package is installed and ran into something that I don't
| understand.
|
| The Makefile contains INSTALLS_ICONS=yes, which has the side effect of
| setting USES+=gnome, USE_GNOME+=gtk-update-icon-cache, and
| _USES_install+=690:gnome-post-install, and that target is responsible
| for parsing ${TMPPLIST} and invoking gtk-update-icon-cache as needed.
| I do see gtk-update-icon-cache in the dependency list in +MANIFEST, so
| it appears that INSTALLS_ICONS=yes is being detected.
|
| It appears that things go wrong because I'm using the Makefile
| post-install target to generate the plist. If I look at bsd.port.mk, I
| see that _STAGE_SEQ contains 700:post-install. It looks to me like
| gnome-post-install is getting run before the plist is generated, which
| would explain why gnome-post-install isn't detecting any icons and not
| invoking gtk-update-icon-cache.
|
| Why is gnome-post-install earlier than post-install, which at least some
| ports use to do plist generation? Some ports do plist generation in
| do-install, but that doesn't work if there are do-install option helpers
| because those get run after the main do-install target.
|
| There is the TARGET_ORDER_OVERRIDE knob, but it is very lightly used.
It is there exactly for the problem you have, change the order targets are
run for one port.
And it is very lightly used because it's only needed when you do some
strange things that nobody else does ;-)
For example, I just added it to devel/p5-ReadLine-TTYtter because I needed
to run post-install before fix-perl-things. And it was ok to do it because
it's a somewhat unique case.
So, basically, you need to put:
TARGET_ORDER_OVERRIDE= 650:post-install
so that it's ran before gnome-post-install, and you're set.
Now, I don't have a problem with moving gnome-post-install after
post-install (like, 710), which would also fix your problem, but it will
need an exp-run to make sure nothing breaks.
--
Mathieu Arnold
--==========B3C56815D48710D83669==========
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQJ8BAEBCgBmBQJW8AbJXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IpuoQALwFZ3vqkxvHehVpJTveEYQw
f35th4ivW7CPCGqF+k4bX/5JLiAOJEqFjjOUssVgJQ1sg3NLDukPihwsAvlawrVn
t4D3ot6LED2DuB/7GactoBVKgK4RGNI4Xhwofp4jkNU3h41k93z12FMGx+9Pp+3d
gAsBP/zCLlOLjPy0Zx95mArQlnfk4r+84AewvI2jyRsfKpp6xr7UTPXZrnbvQGTk
WuyzmerK45Vd+pzUho9UlV8/TNRzxBcbiyT7j+tWpy4BROO9J1u04Bu9Ri8LdZDp
fk6dq8BNT2Gy8hp9SafremKgxri76nXdjEUOwGytwxMCYGRDP8gSas3LmFFRuWDq
0lNaq5hI+Bhd/4rsVQ1Friv7Fm3BQVjyFyemMmbdHI7lwXK13Q+Ab/X3Ttj/PwK7
x4T7iApdXW2UVaLlTmLoeBhpeRtZdQ2yUa3En8M5v2FITjMiEyWmijsz5fC5KZnb
ASDdJZ9eLBsasFYNcA9Li7WKF8XcBoO9guIs8pbNf5qm1U/aKwWnWfuYSY5pX4LM
NZO49Dg7UBpm+MYbk7vKx2gMfOkgLGY/HOmZK9LnBpdC8jPvb3UN5NRjs2nP4m+h
VKWwwlonLf7WJSCKfk0qG01eXFldOhRzGZ1E4VwjVY7jG735fm8jO4Tkxbha0plq
l088g7N/97L0+h+CIBMN
=gwWy
-----END PGP SIGNATURE-----
--==========B3C56815D48710D83669==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8EB21981928900BCB811B4B1>