Date: Sun, 21 Jun 2009 17:59:36 +0100 From: Rui Paulo <rpaulo@freebsd.org> To: Michael <freebsdusb@bindone.de> Cc: freebsd-acpi@freebsd.org Subject: Re: Two new acpi modules, acpi_wmi and acpi_hp Message-ID: <8F2C596E-1B49-4E15-ACC0-84C1A14BD245@freebsd.org> In-Reply-To: <4A3E6563.7040400@bindone.de> References: <4A3E1784.2050406@bindone.de> <5AFA3C27-D3DB-48DA-9AF3-9E14D11EEC61@freebsd.org> <C0DCC4DA-5E4C-46B2-9B84-4EBBC5920B3D@freebsd.org> <4A3E6563.7040400@bindone.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21 Jun 2009, at 17:52, Michael wrote: > Rui Paulo wrote: >> On 21 Jun 2009, at 15:08, Rui Paulo wrote: >> >>> On 21 Jun 2009, at 12:20, Michael wrote: >>> >>>> Hello, >>>> >>>> I wrote two new acpi modules last year and finally found the time >>>> to fix >>>> them, add some missing features and write man pages. >>> >>> Michael, this is great work! I'll review and see if we can ship it >>> with 8.0! >> >> Michael, this looks good, but there are two style nits that we need >> to fix. >> * we should try not going over the 80 column mark >> * add a empty new line before every return >> >> If you could send me a new patch for 8.0 with these fixes, I'll >> commit >> it (unless someone else has objections). >> >> Regards, >> -- >> Rui Paulo >> > > Hi Rui, > > I figured that adding newlines in conditional returns makes no sense > (see my last post), so I did reformat everything to be (close to) 80 > columns a line add added newlines in front of returns at the end of a > function. Yeah, forget about the newlines before return. > Please find attached the complete patch again (against clean > 7.2-RELEASE) and the files that changed (acpi_hp.c and acpi_wmi.c). Can you send it in MIME format or store it at some webserver so I could fetch it? > Btw, what is the normal adoption path for 7-STABLE (I would assume > first > it gets into HEAD and if there's interest there will be a backport > to 7? > It should at least work in there, even so for HP laptops my guess is > that most users will use 8 anyway because of wireless support). It first goes into 8.0 and then 7-STABLE. Thanks, -- Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8F2C596E-1B49-4E15-ACC0-84C1A14BD245>