Date: Mon, 18 Apr 2022 21:47:03 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Mahesh Vardhamanaiah <maheshmv@juniper.net>, "freebsd-usb@freebsd.org" <freebsd-usb@freebsd.org> Cc: Steve Kiernan <stevek@juniper.net>, Justin Hibbits <jhibbits@juniper.net>, Kumara N Babu <bkumara@juniper.net>, Kamal Prasad <krprasad@juniper.net>, Kristof Provost <kp@FreeBSD.org>, "Bjoern A. Zeeb" <bz@FreeBSD.org> Subject: Re: xhci data toggle out of sync Message-ID: <8f51424d-7d1a-9f0a-a0ba-27b02cab0942@selasky.org> In-Reply-To: <PH0PR05MB7782707B34F020611B7FA6C3D5F39@PH0PR05MB7782.namprd05.prod.outlook.com> References: <PH0PR05MB778212B54B636F87C246F62AD5F39@PH0PR05MB7782.namprd05.prod.outlook.com> <61bc4594-f2d3-17c4-42b5-0297ffd78fa3@selasky.org> <PH0PR05MB7782707B34F020611B7FA6C3D5F39@PH0PR05MB7782.namprd05.prod.outlook.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------b1O056sgZ9Ha9OnQoYpLxE0n Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, I think I see what is going on there. I believe this commit is a regression after r365239, that the XHCI driver only resets the data toggle when a STALL PID or USB error is received! But that is not the case for the BULK OUT endpoint, in your traces, because USB mass storage has two endpoints. https://svnweb.freebsd.org/changeset/base/365239 Can you try the attached patch instead of reverting that commit and see if the XHCI now sends a DATA0, as expected? Bjoern and Kristof, can you also test this patch? --HPS --------------b1O056sgZ9Ha9OnQoYpLxE0n Content-Type: text/x-patch; charset=UTF-8; name="a.diff" Content-Disposition: attachment; filename="a.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3N5cy9kZXYvdXNiL2NvbnRyb2xsZXIveGhjaS5jIGIvc3lzL2Rldi91 c2IvY29udHJvbGxlci94aGNpLmMKaW5kZXggZjk1OTk2YjdhYjMuLmViODgxNDBjZjU1IDEw MDY0NAotLS0gYS9zeXMvZGV2L3VzYi9jb250cm9sbGVyL3hoY2kuYworKysgYi9zeXMvZGV2 L3VzYi9jb250cm9sbGVyL3hoY2kuYwpAQCAtMzgyNSw2ICszODI1LDEzIEBAIHhoY2lfY29u ZmlndXJlX3Jlc2V0X2VuZHBvaW50KHN0cnVjdCB1c2JfeGZlciAqeGZlcikKIAkJZXJyID0g eGhjaV9jbWRfc3RvcF9lcChzYywgMCwgZXBubywgaW5kZXgpOwogCQlpZiAoZXJyICE9IDAp CiAJCQlEUFJJTlRGKCJDb3VsZCBub3Qgc3RvcCBlbmRwb2ludCAldVxuIiwgZXBubyk7CisJ CS8qCisJCSAqIE5lZWQgdG8gcmVzZXQgdGhlIGRhdGEgdG9nZ2xlLCBiZWNhdXNlIHN0b3AK KwkJICogZW5kcG9pbnQgZG9lc24ndCBkbyB0aGF0OgorCQkgKi8KKwkJZXJyID0geGhjaV9j bWRfcmVzZXRfZXAoc2MsIDAsIGVwbm8sIGluZGV4KTsKKwkJaWYgKGVyciAhPSAwKQorCQkJ RFBSSU5URigiQ291bGQgbm90IHJlc2V0IGVuZHBvaW50ICV1XG4iLCBlcG5vKTsKIAkJYnJl YWs7CiAJfQogCg== --------------b1O056sgZ9Ha9OnQoYpLxE0n--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8f51424d-7d1a-9f0a-a0ba-27b02cab0942>