Date: Fri, 26 Apr 2013 18:59:20 +0000 From: "Moore, Robert" <robert.moore@intel.com> To: Benjamin Lee <ben@b1c1l1.com> Cc: "freebsd-acpi@freebsd.org" <freebsd-acpi@freebsd.org>, "Guan, Chao" <chao.guan@intel.com>, "Zheng, Lv" <lv.zheng@intel.com> Subject: RE: panic: acpi_pci_link_srs_from_crs: can't put non-ISA IRQ 20 in legacy IRQ resource type) Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E36FE44F8D@FMSMSX153.amr.corp.intel.com> In-Reply-To: <20130426113948.10b5400e@b1c1l1.com> References: <20130418124940.47e3618a@b1c1l1.com> <201304191726.31089.jhb@freebsd.org> <20130419152110.213c7fbb@b1c1l1.com> <201304200817.15189.jhb@freebsd.org> <20130421101728.6fc33a96@b1c1l1.com> <94F2FBAB4432B54E8AACC7DFDE6C92E36FE43F55@FMSMSX153.amr.corp.intel.com> <20130426113948.10b5400e@b1c1l1.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> -----Original Message----- > From: Benjamin Lee [mailto:ben@b1c1l1.com] > Sent: Friday, April 26, 2013 11:40 AM > To: Moore, Robert > Cc: John Baldwin; freebsd-acpi@freebsd.org; Zheng, Lv; Guan, Chao > Subject: Re: panic: acpi_pci_link_srs_from_crs: can't put non-ISA IRQ 20 > in legacy IRQ resource type) >=20 > On Thu, 25 Apr 2013 02:28:25 +0000, "Moore, Robert" > <robert.moore@intel.com> wrote: > > > Thank you! I backed out my hacks and with your 2 patches 10-CURRENT > > > boots successfully (with functional devices). Loading a custom ASL > > > is not necessary. > > > > Do you mean that the change of a WORD field to a BYTE field is no longe= r > necessary? > > > > If so, I would really like to see the buffer that is being sent to _SRS= . >=20 > Yes, the change of WORD to BYTE is not necessary with 10-CURRENT. >=20 > I don't understand ACPI well enough to answer your followup. All I know > is that there is some change in the ACPI parsing behavior between 9-STABL= E > (which triggers AE_AML_BUFFER_LIMIT in the broken _SRS method) and 10- > CURRENT (which used to panic but after jhb's fixes now boots correctly). > Could it be possible that _SRS is not being called at all with the new > ACPI code? >=20 _SRS is called from the driver software, so ACPICA is not involved. It may = be that the resource descriptor is now a little longer and the WORD access = no longer goes beyond the end of the buffer. Still, I'm a bit worried about it anyway. >=20 > -- > Benjamin Lee > http://www.b1c1l1.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?94F2FBAB4432B54E8AACC7DFDE6C92E36FE44F8D>