Date: Wed, 29 May 2002 07:09:21 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Marcel Moolenaar <marcel@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/sys gpt.h Message-ID: <9551.1022648961@critter.freebsd.dk> In-Reply-To: Your message of "Tue, 28 May 2002 19:58:41 PDT." <200205290258.g4T2wgF83137@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200205290258.g4T2wgF83137@freefall.freebsd.org>, Marcel Moolenaar w rites: >marcel 2002/05/28 19:58:41 PDT > > Modified files: > sys/sys gpt.h > Log: > Add attribute packed to struct gpt_hdr to avoid unwanted padding at > the end of the struct to make it an integral number of "longs" on > 64-bit architectures. The size of the struct must be 92, not 96. I think the correct thing to do would be to add a pack/unpack function like it is already done in geom_bsd, geom_sun and geom_mbr. That way the alignment and wordsize of the local platform doesn't matter. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9551.1022648961>