Date: Tue, 28 Jul 2009 21:55:38 +0200 From: Ivan Voras <ivoras@freebsd.org> To: Harald Schmalzbauer <h.schmalzbauer@omnilan.de> Cc: Dimitry Andric <dimitry@andric.com>, freebsd-current@freebsd.org Subject: Re: gmirror provider name limit [Was: Re: geom_label: gpt/labelname for gmirror provider?] Message-ID: <9bbcef730907281255u3f426923g886893585899d210@mail.gmail.com> In-Reply-To: <4A6F52BE.9000901@omnilan.de> References: <4A5CB2D1.5070106@omnilan.de> <h3iegi$kpu$1@ger.gmane.org> <4A5CC981.8010000@omnilan.de> <4A5EDA14.8000703@omnilan.de> <4A5F0F4F.5060505@andric.com> <4A6F52BE.9000901@omnilan.de>
next in thread | previous in thread | raw e-mail | index | archive | help
2009/7/28 Harald Schmalzbauer <h.schmalzbauer@omnilan.de>: > Dimitry Andric schrieb am 16.07.2009 13:30 (localtime): >> >> On 2009-07-16 09:43, Harald Schmalzbauer wrote: >>> >>> I found that the name of the provider for gmirror mustn't exceed 15 >>> characters. `gmirror` doesn't complain if you specify a provider name l= onger >>> that 15 characters, but the mirror won't be detected. >>> So for example it's impossible to use gptid as provider. >>> At least this should be documented in the man page(es, I guess this >>> restriction applies to graid3 etc. also) >> >> As far as I can see, this limit applies to gconcat, gjournal, gmirror, >> graid3, gshsec and gstripe: >> >> sys/geom/concat/g_concat.h:96: =C2=A0char =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0md_provider[16]; /* >> Hardcoded provider. */ >> sys/geom/journal/g_journal.h:292: =C2=A0 =C2=A0 =C2=A0 char =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0md_provider[16]; >> /* Hardcoded provider. */ >> sys/geom/mirror/g_mirror.h:250: char =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0md_provider[16]; /* >> Hardcoded provider. */ >> sys/geom/raid3/g_raid3.h:281: =C2=A0 char =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0md_provider[16]; /* >> Hardcoded provider. */ >> sys/geom/shsec/g_shsec.h:88: =C2=A0 =C2=A0char =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0md_provider[16]; /* >> Hardcoded provider. */ >> sys/geom/stripe/g_stripe.h:91: =C2=A0char =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0md_provider[16]; /* >> Hardcoded provider. */ > > Are there any problems to expect when extending the array size? If you mean the char array of the provider name then yes, it cannot be done without introducing a new metadata version (and then if it fits). > To make use og gptid it had to be 43. I don't follow you on this - why gptid and why 43? --=20 f+rEnSIBITAhITAhLR1nM9F4cIs5KJrhbcsVtUIt7K1MhWJy1A=3D=3D
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9bbcef730907281255u3f426923g886893585899d210>