Date: Sun, 20 Jun 2010 18:25:58 -0700 From: Garrett Cooper <gcooper@FreeBSD.org> To: Ivan Voras <ivoras@freebsd.org> Cc: Andrew Pantyukhin <infofarmer@freebsd.org>, Perforce Change Reviews <perforce@freebsd.org>, Julien LAFFAYE <jlaffaye@freebsd.org> Subject: Re: PERFORCE change 180026 for review Message-ID: <AANLkTils97pZPnrVCG3qUY_B5iCcnTGPgxxeqpWRvWOO@mail.gmail.com> In-Reply-To: <AANLkTimpzTbsP_2ztEZd6S5Cxhyga54PWYwAhCFYVtuP@mail.gmail.com> References: <201006210045.o5L0jgZ3009138@repoman.freebsd.org> <AANLkTilVcTOnaHwihB4IZVi7KZldCrD2Ion28XCSuOgg@mail.gmail.com> <AANLkTimpzTbsP_2ztEZd6S5Cxhyga54PWYwAhCFYVtuP@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 20, 2010 at 6:15 PM, Ivan Voras <ivoras@freebsd.org> wrote: > On 21 June 2010 02:58, Julien LAFFAYE <jlaffaye@freebsd.org> wrote: >> Hi, >> >> On Sun, Jun 20, 2010 at 5:45 PM, Ivan Voras <ivoras@freebsd.org> wrote: >>> >>> http://p4web.freebsd.org/@@180026?ac=3D10 >>> >>> Change 180026 by ivoras@betelgeuse on 2010/06/21 00:45:03 >>> >>> =A0 =A0 =A0 =A0Finished most of +CONTENTS reading code, still a few thi= ngs to go >>> =A0 =A0 =A0 =A0and certainly edge-cases resulting from the uglyness and= adhockery >>> =A0 =A0 =A0 =A0of the format. >>> >> >> Why don't you use read_plist(Package *pkg, int fd) from libpkg instead? > > Should I, in the light of > YES_I_KNOW_THE_API_IS_RUBBISH_AND_IS_DOOMED_TO_CHANGE ? I thought the > entire lib is to be rightfully scrapped and implemented as something > decent. Yes, it will be eventually, but there's no real harm in implementing this bit with read_plist for the time being though. If and when dforsyth's work gets straightened out, a lot of this crud will get scrapped and/or properly rewritten. Thanks, -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTils97pZPnrVCG3qUY_B5iCcnTGPgxxeqpWRvWOO>