Date: Wed, 9 Feb 2011 02:29:39 +0800 From: Sunpoet Hsieh <sunpoet@sunpoet.net> To: arrowdodger <6yearold@gmail.com> Cc: freebsd-ports@freebsd.org Subject: Re: Request for new port review: TortoiseHG. Message-ID: <AANLkTimHUP5YvMrLuJ9NKET0=FyEO-M-5P8GJAJeU%2Bek@mail.gmail.com> In-Reply-To: <AANLkTin%2BCskJf8vP9iZwRvtC%2B66F%2BD6VPr6JbbO4v6pT@mail.gmail.com> References: <AANLkTin%2BCskJf8vP9iZwRvtC%2B66F%2BD6VPr6JbbO4v6pT@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
First of all, I suggest to set PORTNAME=3Dtortoisehg
If you do want to add -hgtk suffix, you may set PKGNAMESUFFIX=3D-hgtk inste=
ad.
It makes portlint happier.
It also simplifies Makefile since DISTNAME is already the default value.
On Tue, Feb 8, 2011 at 7:40 PM, arrowdodger <6yearold@gmail.com> wrote:
> Hello. I've made a port for TortoiseHG (in fact, for its hgtk script). It=
is
> my first attempt in port creation, so i want someone to review it.
>
> The current problems are following:
> 1. The user can choose to not install nautilus extension and translation
> files (if defined(WITHOUT_NLS)). To prevent setup.py from installing thos=
e
> stuff, i've made two patches, that resides in ${FILESDIR}. They are
> generated from 'diff -u' and the problem is that they cannot be applied
> together. If i generate patches with simply 'diff', then everythink works=
,
> except that i should apply them manually (${PATCH} ${PYSETUP} <
> ${FILESDIR}/no-locale.patch).
> And what i've been told is that i should use EXTRA_PATCHES, insteand of
> invoking patch.
>
In your case, it can be done without extra patch files.
.if !defined(WITH_NAUTILUS)
@${REINPLACE_CMD} -e '153,154 D' ${WRKSRC}/${PYSETUP}
.endif
.if !defined(WITH_NLS)
@${REINPLACE_CMD} -e '150,152 D' ${WRKSRC}/${PYSETUP}
.endif
Here, I suggest a shorter option name "NAUTILUS" instead of
"NAUTILUS_EXTENSION".
Also, for PLIST_SUB, I think "NLS" is OK for most ports.
.if !defined(WITH_NLS)
PLIST_SUB+=3D NLS=3D"@comment "
.else
PLIST_SUB+=3D NLS=3D""
.endif
> 2. The port also installs *.egg-info file and i'm not sure how to include=
it
> in the plist.
You should set PYDISTUTILS_EGGINFO=3D<egg-info files>.
bsd.python.mk will add them to PLIST automatically.
PYDISTUTILS_EGGINFO defaults to tortoisehg-1.1.9.1-py2.6.egg-info.
(when PORTNAME=3Dtortoisehg)
> 3. The port also depends on py-gobject port, but there is no such value i=
n
> USE_GNOME. I've already mentioned that on freebsd-gnome@ and they said, t=
hat
> it will be fixed after 8.2-RELEASE.
>
> You can obtain port from attachement or here:
> http://intara.org.ru/tortoisehg.tar.gz
>
> Thanks in advance.
Hope that helps.
Regards,
--=20
=C2=A0 Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.=
org>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B =
8CC0 DC44 247E CC57 E36B
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 http://people.FreeBSD.org/~sunpoet/pgpkeys.txt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimHUP5YvMrLuJ9NKET0=FyEO-M-5P8GJAJeU%2Bek>