Date: Wed, 10 Nov 2010 00:44:41 -0800 From: Garrett Cooper <gcooper@FreeBSD.org> To: Marcel Moolenaar <xcllnt@mac.com> Cc: hackers@freebsd.org Subject: Re: [PATCH] Simplify uart_bus_pci_probe Message-ID: <AANLkTimtEVSAYOnw3OonJR3tmYpKmiw0Wsby-OcPQvgJ@mail.gmail.com> In-Reply-To: <478E6244-00B4-4D96-93FE-CBD546C27A6E@mac.com> References: <AANLkTimMt4Ucm%2BfRipzk3sq0M=1DNaC6EGQJ8M0ZWwob@mail.gmail.com> <478E6244-00B4-4D96-93FE-CBD546C27A6E@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 9, 2010 at 10:29 PM, Marcel Moolenaar <xcllnt@mac.com> wrote:
>
> On Nov 6, 2010, at 11:22 AM, Garrett Cooper wrote:
>
>> Some of the logic could have been simplified in the probe. The
>> proposed patch makes the detection process a tad bit more
>> straightforward.
>> Comments, review (and maybe a commit :P) are more than welcome :).
>
> The patch is logically wrong for non-ns8250 based UARTs.
> Leave the code as is.
Hi Marcel,
Is the layout of the pci_ns8250_ids PCI ID table correct then, as
there are a large number of ns16550 chips and other non-ns8250 chips
in the table?
Thanks,
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimtEVSAYOnw3OonJR3tmYpKmiw0Wsby-OcPQvgJ>