Date: Tue, 5 Oct 2010 20:19:45 +0000 From: Paul B Mahol <onemda@gmail.com> To: freebsd-net@freebsd.org Subject: ndis: fix ugly code Message-ID: <AANLkTinpUmhczHu1mmtuO1BaibSpT1xUG0PY-Km8wHvL@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
--000e0cd30a92cb96980491e46145 Content-Type: text/plain; charset=ISO-8859-1 Hi, If clang did not complain, I would probbaly never spot it. Patch attached. --000e0cd30a92cb96980491e46145 Content-Type: text/plain; charset=US-ASCII; name="ndis.txt" Content-Disposition: attachment; filename="ndis.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: file0 ZGlmZiAtLWdpdCBhL3N5cy9jb21wYXQvbmRpcy9zdWJyX250b3Nrcm5sLmMgYi9zeXMvY29tcGF0 L25kaXMvc3Vicl9udG9za3JubC5jCmluZGV4IGJhMWU0OWYuLjcxNGZjZDggMTAwNjQ0Ci0tLSBh L3N5cy9jb21wYXQvbmRpcy9zdWJyX250b3Nrcm5sLmMKKysrIGIvc3lzL2NvbXBhdC9uZGlzL3N1 YnJfbnRvc2tybmwuYwpAQCAtMjc0LDcgKzI3NCw2IEBAIG50b3Nrcm5sX2xpYmluaXQoKQogCWtk cGNfcXVldWUJCSprcTsKIAljYWxsb3V0X2VudHJ5CQkqZTsKIAlpbnQJCQlpOwotCWNoYXIJCQlu YW1lWzY0XTsKIAogCW10eF9pbml0KCZudG9za3JubF9kaXNwYXRjaGxvY2ssCiAJICAgICJudG9z a3JubCBkaXNwYXRjaCBsb2NrIiwgTVRYX05ESVNfTE9DSywgTVRYX0RFRnxNVFhfUkVDVVJTRSk7 CkBAIC0zMjEsOSArMzIwLDggQEAgbnRvc2tybmxfbGliaW5pdCgpCiAjZW5kaWYKIAkJa3EgPSBr cV9xdWV1ZXMgKyBpOwogCQlrcS0+a3FfY3B1ID0gaTsKLQkJc3ByaW50ZihuYW1lLCAiV2luZG93 cyBEUEMgJWQiLCBpKTsKIAkJZXJyb3IgPSBrcHJvY19jcmVhdGUobnRvc2tybmxfZHBjX3RocmVh ZCwga3EsICZwLAotCQkgICAgUkZISUdIUElELCBORElTX0tTVEFDS19QQUdFUywgbmFtZSk7CisJ CSAgICBSRkhJR0hQSUQsIE5ESVNfS1NUQUNLX1BBR0VTLCAiV2luZG93cyBEUEMgJWQiLCBpKTsK IAkJaWYgKGVycm9yKQogCQkJcGFuaWMoImZhaWxlZCB0byBsYXVuY2ggRFBDIHRocmVhZCIpOwog CX0KQEAgLTMzNCw5ICszMzIsOCBAQCBudG9za3JubF9saWJpbml0KCkKIAogCWZvciAoaSA9IDA7 IGkgPCBXT1JLSVRFTV9USFJFQURTOyBpKyspIHsKIAkJa3EgPSB3cV9xdWV1ZXMgKyBpOwotCQlz cHJpbnRmKG5hbWUsICJXaW5kb3dzIFdvcmtpdGVtICVkIiwgaSk7CiAJCWVycm9yID0ga3Byb2Nf Y3JlYXRlKG50b3Nrcm5sX3dvcmtpdGVtX3RocmVhZCwga3EsICZwLAotCQkgICAgUkZISUdIUElE LCBORElTX0tTVEFDS19QQUdFUywgbmFtZSk7CisJCSAgICBSRkhJR0hQSUQsIE5ESVNfS1NUQUNL X1BBR0VTLCAiV2luZG93cyBXb3JraXRlbSAlZCIsIGkpOwogCQlpZiAoZXJyb3IpCiAJCQlwYW5p YygiZmFpbGVkIHRvIGxhdW5jaCB3b3JraXRlbSB0aHJlYWQiKTsKIAl9CkBAIC0zMzgyLDcgKzMz NzksNiBAQCBQc0NyZWF0ZVN5c3RlbVRocmVhZChoYW5kbGUsIHJlcWFjY2Vzcywgb2JqYXR0cnMs IHBoYW5kbGUsCiAJdm9pZAkJCSp0aHJjdHg7CiB7CiAJaW50CQkJZXJyb3I7Ci0JY2hhcgkJCXRu YW1lWzEyOF07CiAJdGhyZWFkX2NvbnRleHQJCSp0YzsKIAlzdHJ1Y3QgcHJvYwkJKnA7CiAKQEAg LTMzOTMsOSArMzM4OSw4IEBAIFBzQ3JlYXRlU3lzdGVtVGhyZWFkKGhhbmRsZSwgcmVxYWNjZXNz LCBvYmphdHRycywgcGhhbmRsZSwKIAl0Yy0+dGNfdGhyY3R4ID0gdGhyY3R4OwogCXRjLT50Y190 aHJmdW5jID0gdGhyZnVuYzsKIAotCXNwcmludGYodG5hbWUsICJ3aW5kb3dzIGt0aHJlYWQgJWQi LCBudG9za3JubF9rdGgpOwogCWVycm9yID0ga3Byb2NfY3JlYXRlKG50b3Nrcm5sX3RocmZ1bmMs IHRjLCAmcCwKLQkgICAgUkZISUdIUElELCBORElTX0tTVEFDS19QQUdFUywgdG5hbWUpOworCSAg ICBSRkhJR0hQSUQsIE5ESVNfS1NUQUNLX1BBR0VTLCAiV2luZG93cyBLdGhyZWFkICVkIiwgbnRv c2tybmxfa3RoKTsKIAogCWlmIChlcnJvcikgewogCQlmcmVlKHRjLCBNX1RFTVApOwo= --000e0cd30a92cb96980491e46145--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTinpUmhczHu1mmtuO1BaibSpT1xUG0PY-Km8wHvL>